Release 0.7.1 #160

nicoddemus · 2018-07-27T01:43:31Z

OK now we are in business.

Had to call git commit directly in the commit script because apparently gitpython bypasses the local configuration (don't have time right now to look for another solution).

Other than that, I changed #131 and #66 from feature to trivial, as those are more internal changes than user-facing features.

Those are more internal changes than user-facing features

Otherwise it will bypass some configuration options in the system, specially autocrlf option which will mess up line endinds on Windows :/

goodboy · 2018-07-27T12:15:57Z

So this is where we click merge and everything just happens?

RonnyPfannschmidt · 2018-07-27T12:20:23Z

@tgoodlet it still needs a tag as well

nicoddemus · 2018-07-27T12:24:15Z

Yep just pushed the tag. Now Travis should deploy it for us. After that we can merge. 😁

goodboy · 2018-07-27T13:48:45Z

Version conflict in the benchmark tests?

nicoddemus · 2018-07-27T14:33:39Z

Bummer:

pkg_resources.ContextualVersionConflict: (pluggy 0.7.0 (/home/travis/build/pytest-dev/pluggy/.tox/benchmark/lib/python3.6/site-packages), Requirement.parse('pluggy<0.7,>=0.5'), {'pytest'})

pytest requires pluggy<0.7... not sure why this didn't blow up with the other jobs. 🤔

goodboy · 2018-07-27T14:53:18Z

@nicoddemus maybe a race with the PyPi upload? Benchmark tests are the last job?

nicoddemus · 2018-07-27T15:03:09Z

No, it is a conflict with the pluggy being built...

It is weird because the other jobs installed pytest and pluggy even with the restriction in place:

py27release

============================= test session starts ==============================
platform linux2 -- Python 2.7.14, pytest-3.6.3, py-1.5.4, pluggy-0.7.0

Back to the job with the problem, it also seems we have a hidden bug in pluggy:

  File "/home/travis/build/pytest-dev/pluggy/.tox/benchmark/lib/python3.6/site-packages/pluggy/manager.py", line 258, in load_setuptools_entrypoints
    "Plugin %r could not be loaded: %s!" % (ep.name, e))
TypeError: __init__() missing 1 required positional argument: 'message'

EDIT:

Yep:

pluggy/pluggy/manager.py

Lines 256 to 258 in 8294801

    
           except VersionConflict as e: 
        
               raise PluginValidationError( 
        
                   "Plugin %r could not be loaded: %s!" % (ep.name, e))

nicoddemus · 2018-07-27T17:43:38Z

I propose that we skip the benchmark job when making releases. As #164 shows, it is failing when loading the benchmark entry point, but is not the fault of the benchmark specifically because it does not pin pluggy. I'm guessing it is a problem with pip's dependency solver.

nicoddemus · 2018-07-28T12:42:50Z

Another solution is to release a new pytest version with pluggy<0.8 pinnings.

nicoddemus · 2018-07-28T13:15:25Z

Started pytest 3.6.4 which loosens the pin a bit to pluggy<0.8: pytest-dev/pytest#3728

Seems like the easiest solution for now because we won't need to change anything on pluggy. Still, it is an interesting problem because it doesn't seem to exist a direct solution to this, they are all compromises.

…try points

Mark 0.7.0 as unreleased due to deployment problems in pytest-dev#160

nicoddemus · 2018-07-28T16:11:03Z

With the new pytest released which pins to pluggy<0.8 this should now work. I've also cherry-picked the fix in #164 to here.

I had to manually update the changelog to mark 0.7.0 as never released to PyPI, let me know if you guys thinks that is fine.

RonnyPfannschmidt · 2018-07-28T16:40:44Z

CHANGELOG.rst

@@ -1,4 +1,4 @@
-Pluggy 0.7.0 (2018-07-26)
+pluggy 0.7.1 (2018-07-28)


a p is missinghere

RonnyPfannschmidt · 2018-07-28T16:40:56Z

CHANGELOG.rst

@@ -1,4 +1,4 @@
-Pluggy 0.7.0 (2018-07-26)
+pluggy 0.7.1 (2018-07-28)
 =========================

 Deprecations and Removals


RonnyPfannschmidt · 2018-07-28T16:41:14Z

i beleive the templates are broken for multiple projects

nicoddemus · 2018-07-28T17:53:08Z

Actually it is a problem with the GH extension we use, see my other replies 😁

goodboy · 2018-07-28T19:42:03Z

So we're good to go here now. Nice job on the bug fix btw @nicoddemus.

nicoddemus · 2018-07-28T19:54:25Z

Yep we just need to push a tag here. Want to do the honors here @tgoodlet? I'm away from the computer now

goodboy · 2018-07-28T20:12:02Z

@nicoddemus tag is 0.7.1 yah?

nicoddemus · 2018-07-28T21:49:11Z

Yes :) Em sáb, 28 de jul de 2018 17:12, goodboy <notifications@github.com> escreveu:

…

@nicoddemus <https://github.com/nicoddemus> tag is 0.7.1 yah? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#160 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABCO_H8fkX8h4UvALa8tv-mL0e6JKWvRks5uLMWTgaJpZM4ViyVx> .

goodboy · 2018-07-28T22:46:12Z

Weird, I totally didn't know you can just push a tag without the branch.
Anyway, think I did it?

goodboy · 2018-07-28T22:55:09Z

Yup. We're live 👍

goodboy · 2018-07-28T22:56:56Z

I guess the only thing remaining is the anaconda package?

nicoddemus · 2018-07-28T23:51:43Z

That happens automatically :)

Because we don't have the highest supported pluggy and pytest-cov versions configured in requirements.txt, pip installs the newest pluggy 0.7.1 which is incompatible with the pytest version we use. For the reference see issues: pytest-dev/pluggy#160 pytest-dev/pytest#3727 Solution is to add pluggy's version restrictions to our requirements. Signed-off-by: Przemyslaw Lal <przemyslawx.lal@intel.com>

nicoddemus · 2018-08-02T23:37:40Z

I guess the only thing remaining is the anaconda package?

@tgoodlet FYI https://github.com/regro-cf-autotick-bot picks up releases to PyPI and automatically opens a PR to update the conda package. 😉

conda-forge/pluggy-feedstock#6

nicoddemus added 3 commits July 26, 2018 22:23

Change pytest-dev#131 and pytest-dev#66 changelog entries to trivial

b22cf1c

Those are more internal changes than user-facing features

Change release command to call git directly

b607b01

Otherwise it will bypass some configuration options in the system, specially autocrlf option which will mess up line endinds on Windows :/

Preparing release 0.7.0

2068553

nicoddemus assigned RonnyPfannschmidt and goodboy Jul 27, 2018

RonnyPfannschmidt approved these changes Jul 27, 2018

View reviewed changes

goodboy approved these changes Jul 27, 2018

View reviewed changes

nicoddemus added a commit to nicoddemus/pluggy that referenced this pull request Jul 27, 2018

Try to reproduce the problem in pytest-dev#160

2c4ecb0

nicoddemus mentioned this pull request Jul 27, 2018

Try to reproduce the problem in #160 #164

Closed

nicoddemus mentioned this pull request Jul 28, 2018

Change pluggy pinning to <0.8 pytest-dev/pytest#3727

Closed

nicoddemus and others added 2 commits July 28, 2018 13:02

Fix error when handling VersionConflict exceptions from setuptools en…

72e4c25

…try points

Run towncrier manually and fix changelog manually

9b48efb

Mark 0.7.0 as unreleased due to deployment problems in pytest-dev#160

nicoddemus changed the title ~~Release 0.7.0~~ Release 0.7.1 Jul 28, 2018

nicoddemus closed this Jul 28, 2018

nicoddemus reopened this Jul 28, 2018

RonnyPfannschmidt reviewed Jul 28, 2018

View reviewed changes

CHANGELOG.rst Outdated

@@ -1,4 +1,4 @@

Pluggy 0.7.0 (2018-07-26)

pluggy 0.7.1 (2018-07-28)

Copy link

Member

RonnyPfannschmidt Jul 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a p is missinghere

RonnyPfannschmidt reviewed Jul 28, 2018

View reviewed changes

nicoddemus merged commit e601df4 into pytest-dev:master Jul 28, 2018

nicoddemus deleted the release-0.7.0 branch July 28, 2018 23:52

przemeklal mentioned this pull request Jul 31, 2018

Add supported pluggy versions to requirements.txt intel/CPU-Manager-for-Kubernetes#197

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release 0.7.1 #160

Release 0.7.1 #160

nicoddemus commented Jul 27, 2018

goodboy commented Jul 27, 2018

RonnyPfannschmidt commented Jul 27, 2018

nicoddemus commented Jul 27, 2018

goodboy commented Jul 27, 2018

nicoddemus commented Jul 27, 2018

goodboy commented Jul 27, 2018

nicoddemus commented Jul 27, 2018 •

edited

Loading

nicoddemus commented Jul 27, 2018 •

edited

Loading

nicoddemus commented Jul 28, 2018

nicoddemus commented Jul 28, 2018

nicoddemus commented Jul 28, 2018

RonnyPfannschmidt Jul 28, 2018

RonnyPfannschmidt Jul 28, 2018

RonnyPfannschmidt commented Jul 28, 2018

nicoddemus commented Jul 28, 2018

goodboy commented Jul 28, 2018

nicoddemus commented Jul 28, 2018

goodboy commented Jul 28, 2018

nicoddemus commented Jul 28, 2018 via email

goodboy commented Jul 28, 2018

goodboy commented Jul 28, 2018

goodboy commented Jul 28, 2018

nicoddemus commented Jul 28, 2018

nicoddemus commented Aug 2, 2018

		@@ -1,4 +1,4 @@
		Pluggy 0.7.0 (2018-07-26)
		pluggy 0.7.1 (2018-07-28)

Release 0.7.1 #160

Release 0.7.1 #160

Conversation

nicoddemus commented Jul 27, 2018

goodboy commented Jul 27, 2018

RonnyPfannschmidt commented Jul 27, 2018

nicoddemus commented Jul 27, 2018

goodboy commented Jul 27, 2018

nicoddemus commented Jul 27, 2018

goodboy commented Jul 27, 2018

nicoddemus commented Jul 27, 2018 • edited Loading

nicoddemus commented Jul 27, 2018 • edited Loading

nicoddemus commented Jul 28, 2018

nicoddemus commented Jul 28, 2018

nicoddemus commented Jul 28, 2018

RonnyPfannschmidt Jul 28, 2018

Choose a reason for hiding this comment

RonnyPfannschmidt Jul 28, 2018

Choose a reason for hiding this comment

RonnyPfannschmidt commented Jul 28, 2018

nicoddemus commented Jul 28, 2018

goodboy commented Jul 28, 2018

nicoddemus commented Jul 28, 2018

goodboy commented Jul 28, 2018

nicoddemus commented Jul 28, 2018 via email

goodboy commented Jul 28, 2018

goodboy commented Jul 28, 2018

goodboy commented Jul 28, 2018

nicoddemus commented Jul 28, 2018

nicoddemus commented Aug 2, 2018

nicoddemus commented Jul 27, 2018 •

edited

Loading

nicoddemus commented Jul 27, 2018 •

edited

Loading