Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize test classes into modules #32

Closed
goodboy opened this issue Nov 12, 2016 · 7 comments
Closed

Reorganize test classes into modules #32

goodboy opened this issue Nov 12, 2016 · 7 comments
Assignees

Comments

@goodboy
Copy link
Contributor

goodboy commented Nov 12, 2016

The testing/test_pluggy.py module is not only a bit long but also overwhelming.

I propose we break up the current organization of as follows:
TestPluginManager -> test_plugin_manager.py
TestAddMethodOrdering -> test_add_method_ordering.py
TestMultiCall -> test_multicall.py
TestHookRelay -> test_hook_relay.py
TestTracer -> test_tracer.py

I personally think it just lends to a better immediate understanding of what tests are available/need to be written around each internal component of the pluggy architecture.

@hpk42
Copy link
Contributor

hpk42 commented Nov 12, 2016

i am fine with such a reorg PR -- please try to make history/blaming continue to work as much as possible.

@goodboy
Copy link
Contributor Author

goodboy commented Nov 16, 2016

@hpk42 yeah I'm not sure I can maintain all that much in terms of blame.
The new modules will be under my name..

Would you rather do it?

@RonnyPfannschmidt
Copy link
Member

people can stil lblame from the old code in case of real interest - since source controll systems do not track code reorg in any repressentign way i think its fine to loose some

@hpk42
Copy link
Contributor

hpk42 commented Nov 16, 2016

@tgoodlet no worries. Try to do all shifts in a single commit and make the commit message descriptive. If neccessary people can figure it out as ronny says. pity that git still does not have a "git cp" although it has a "git mv".

@hpk42
Copy link
Contributor

hpk42 commented Nov 16, 2016

@tgoodlet your avatar logo -- is that purposedly taken from this quite terrifying black mirror episode?

@nicoddemus
Copy link
Member

I'm guessing that's the classic "troll face" 😁

@goodboy
Copy link
Contributor Author

goodboy commented Nov 16, 2016

@hpk42 yeah @nicoddemus is right although it's actually a bit of a story.

My buddy @vodik back in university found my email unlocked and stuck that pic as my avatar. I've been embracing it ever since. I wasn't much of an internet nerd back then so I had no idea where it came from at the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants