Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge pull request #179 from frankie567/issue-178 #179

Merged
merged 3 commits into from
Jan 28, 2020

Conversation

frankie567
Copy link
Contributor

@frankie567 frankie567 commented Jan 25, 2020

Hi there 👋

Took a shot at a fix for #178. Basically, we check if the spied function is a coroutine, and wrap it with an async-friendly wrapper.

Maybe not the most elegant solution, but I'm open to suggestions.

Cheers!

@nicoddemus nicoddemus changed the title Fix #178: handle spy on async functions Merge pull request #179 from frankie567/issue-178 Jan 28, 2020
@nicoddemus nicoddemus merged commit 97f897f into pytest-dev:master Jan 28, 2020
@nicoddemus
Copy link
Member

Excellent solution @frankie567, really appreciate it! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants