spy: handle AttributeError with __getattribute__

[blueyed]

I have noticed that spy did not work on functions that are not defined
in the class itself, but a parent class. This patch fixes this.

[nicoddemus]

Is this supposed to be a classmethod?

[blueyed]

Yep, it is now - I was pushing a fixup/amended commit.

[nicoddemus]

Thanks a lot @blueyed!

Could you please also write a new CHANGELOG entry?

The timing is great, I was planning on publishing a new release today! 😄

[blueyed]

It does not work with Python 2 apparently:

    @skip_pypy
    def test_static_method_subclass_spy(mocker):
        class Base(object):

            @staticmethod
            def bar(arg):
                return arg * 2

        class Foo(Base):
            pass

        spy = mocker.spy(Foo, 'bar')
>       assert Foo.bar(arg=10) == 20
E       TypeError: unbound method bar() must be called with Foo instance as first argument (got nothing instead)

(same with classmethod).

Should the tests be skipped there?

[nicoddemus]

Hmmm that's a shame.

Please xfail them in Python 2 instead (@pytest.mark.xfail(sys.python_version[0] == 2, reason='does not work on Python 2') should do the trick. We can try to make it work later, but the PR as it stands is already an improvement.

[blueyed]

Done.

[nicoddemus]

Thanks again! 😄