Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provide pathlib based paths in compat and plain flavours to enable removal of py.path usage in pytest 3.0 #1260

Closed
RonnyPfannschmidt opened this issue Dec 14, 2015 · 2 comments
Closed

provide pathlib based paths in compat and plain flavours to enable removal of py.path usage in pytest 3.0 #1260

RonnyPfannschmidt opened this issue Dec 14, 2015 · 2 comments
Labels
type: backward compatibility might present some backward compatibility issues which should be carefully noted in the changelog type: enhancement new feature or API change, should be merged into features branch type: proposal proposal for a new feature, often to gather opinions or design the API around the new feature type: refactoring internal improvements to the code

Comments

@RonnyPfannschmidt
Copy link
Member

in order to get rid of the py.path legacy it is neccessary to provide a upgrade path
i propose adding a config option to handle legacy, compat and path based path objects for tmpdir, cache & co

leacy should be the default in the 2.9 release
if there is a 2.10 it should make compat the default

3.0 should drop the legacy and only offer pathlib

the canonical implementation should be pathlib2, since its on a recent state and works on 2.7, and 3.x

the compat flavour should warn with deprecationwarning subclasses to note the method removal in pytest 3.0
@RonnyPfannschmidt RonnyPfannschmidt added type: enhancement new feature or API change, should be merged into features branch type: proposal proposal for a new feature, often to gather opinions or design the API around the new feature type: backward compatibility might present some backward compatibility issues which should be carefully noted in the changelog type: refactoring internal improvements to the code labels Dec 14, 2015
@RonnyPfannschmidt RonnyPfannschmidt added this to the 2.9 milestone Dec 14, 2015
@RonnyPfannschmidt RonnyPfannschmidt mentioned this issue Dec 23, 2015
Merged
@The-Compiler The-Compiler modified the milestones: 2.10, 2.9 Feb 26, 2016
@nicoddemus nicoddemus modified the milestones: 2.10, 3.0 Jun 26, 2016
@RonnyPfannschmidt RonnyPfannschmidt removed this from the 3.0 milestone Jul 19, 2016
@RonnyPfannschmidt
Copy link
Member Author

clearing the milestone, perhaps aiming for 4.0 is more realistic

@rth rth mentioned this issue May 29, 2018
Merged
@Zac-HD
Copy link
Member

Zac-HD commented Oct 21, 2018

Closed by #3988, I think - py.path is only a shim now and emits deprecation warnings 🎉

@Zac-HD Zac-HD closed this as completed Oct 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: backward compatibility might present some backward compatibility issues which should be carefully noted in the changelog type: enhancement new feature or API change, should be merged into features branch type: proposal proposal for a new feature, often to gather opinions or design the API around the new feature type: refactoring internal improvements to the code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@RonnyPfannschmidt @The-Compiler @nicoddemus @Zac-HD