Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiprocessing broken since 2.7.1 on Windows #749

Closed
pytestbot opened this issue May 20, 2015 · 8 comments
Closed

multiprocessing broken since 2.7.1 on Windows #749

pytestbot opened this issue May 20, 2015 · 8 comments
Labels
type: bug problem that needs to be addressed

Comments

@pytestbot
Copy link
Contributor

Originally reported by: Marc Schlaich (BitBucket: schlamar, GitHub: schlamar)


With pytest 2.7.1, Processes with multiprocessing don't start anymore, I'm seeing this in stdout:

Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "c:\python27\Lib\multiprocessing\forking.py", line 380, in main
    prepare(preparation_data)
  File "c:\python27\Lib\multiprocessing\forking.py", line 488, in prepare
    assert main_name not in sys.modules, main_name
AssertionError: __main__

This is probably due to this upstream issue with wheels: pypa/pip#1891

Installing pytest not as wheel with pip install --no-use-wheel resolves this issue.


@pytestbot
Copy link
Contributor Author

Original comment by Floris Bruynooghe (BitBucket: flub, GitHub: flub):


As you say this appear to be a wheel issue. Is the suggestion we remove the wheel again until the referenced issue gets fixed? Not sure what else we can do really.

@pytestbot
Copy link
Contributor Author

Original comment by Bruno Oliveira (BitBucket: nicoddemus, GitHub: nicoddemus):


I guess that would be the correct approach, IMO.

@pytestbot
Copy link
Contributor Author

Original comment by Marc Schlaich (BitBucket: schlamar, GitHub: schlamar):


Yes. This is what autopep8 did, too: hhatto/autopep8#193

@pytestbot
Copy link
Contributor Author

Original comment by Floris Bruynooghe (BitBucket: flub, GitHub: flub):


Sigh, seems like the poor people wanting wheels never get to have their fun.

Since I've heard issues with deleting files on pypi, are we very sure we want to delete it? we might not be able to add it back. And is it completely safe to remove the wheel file from it.

@pytestbot
Copy link
Contributor Author

Original comment by Bruno Oliveira (BitBucket: nicoddemus, GitHub: nicoddemus):


Sigh, seems like the poor people wanting wheels never get to have their fun

Indeed. :(

Since I've heard issues with deleting files on pypi, are we very sure we want to delete it? we might not be able to add it back.

I'm not sure... I think the best policy would be to release a hotfix version of pytest (2.7.2) without wheels, otherwise folks from now on would never be sure if their version was installed using a wheel or not, specially on CI farms and cached virtual envs. sigh

@pytestbot pytestbot added the type: bug problem that needs to be addressed label Jun 15, 2015
@schlamar
Copy link
Contributor

This is not resolved, there are wheels on 2.8.2 :(

@schlamar schlamar reopened this Oct 16, 2015
@The-Compiler
Copy link
Member

HOWTORELEASE.rst says to build wheels, so that's what I did when doing my first release 😉

Honestly, I personally don't think it's the correct solution to avoid building wheels for pytest.

pypa/pip#1891 mentions running wheel install-scripts <packagename> works around this, so I think people should run that instead if possible, or install without wheels.

I think @RonnyPfannschmidt will do the last release, so I'd say his decision if he wants to upload wheels for that or not. I don't know if it's possible to test wheels but not release them to PyPI with devpi and our releasing workflow though, at least testing them would be desirable I think...

@nicoddemus
Copy link
Member

Closing this, as it seems it will be fixed in 2.7.11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug problem that needs to be addressed
Projects
None yet
Development

No branches or pull requests

4 participants