Remove deprecated features #7660
Conversation
| @@ -59,38 +72,46 @@ display captured output when tests fail: ``no``, ``stdout``, ``stderr``, ``log`` | |||
|
|
|||
|
|
|||
|
|
|||
| Node Construction changed to ``Node.from_parent`` | |||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | |||
| Result log (``--result-log``) | |||
There was a problem hiding this comment.
This diff is pretty confusing, suggest to read the full file instead.
| @@ -1315,53 +1306,6 @@ def fixture( # noqa: F811 | |||
| name the decorated function ``fixture_<fixturename>`` and then use | |||
| ``@pytest.fixture(name='<fixturename>')``. | |||
| """ | |||
| # Positional arguments backward compatibility. | |||
| "https://docs.pytest.org/en/stable/deprecations.html#node-construction-changed-to-node-from-parent" | ||
| " for more details." | ||
| ).format(name=self.__name__) | ||
| fail(msg, pytrace=False) |
There was a problem hiding this comment.
@RonnyPfannschmidt I understand that was the intention in the end, correct?
nicoddemus
force-pushed
the
deprecated-features
branch
from
78dbb61
to
6315074
Compare
There was a problem hiding this comment.
The commits look good to me, really nice to get rid of that cruft.
I'm somewhat anxious about "Hard failure when constructing Node subclasses" however. The problem is that the from_parent API cannot be typed properly, and once we disallow direct construction there is no turning back ever. But maybe at this point we should just accept this.
Actually I recall @RonnyPfannschmidt mentioning this was supposed to be transitory, but don't remember the details now. |
|
Yup, until we get rid of the tricky mess in some of the ctors from_parent is a necessity mess |
|
FTR that's what https://github.com/pytest-dev/pytest/projects/3 is about. |
nicoddemus
force-pushed
the
deprecated-features
branch
from
6315074
to
372a094
Compare
This removes all features which have been deprecated over 2 minor versions ago or more.
@RonnyPfannschmidt also removed
resultlog, seems like there's has been enough time for people to trypytest-reportlogand provide feedback.Close #5585