-
-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First pass over generics #1079
First pass over generics #1079
Conversation
for more information, see https://pre-commit.ci
@hynek chants dump 3.6, dump 3.6 |
@Tinche chants coverage, coverage |
Do you plan on finishing this up or can I close it? |
This can be merged, it can just be worked on further, but the further work gets a lot more complex. This first step has value on its own. |
This cannot be merged because it's breaking CI. |
Ah, oops. Will work on it some more. |
Does it maybe only get hit in a version that doesn't run under coverage? |
This was me running coverage locally, on Python 3.11. Going to try working on this some more. |
Ok, I got it. Running coverage with this configuration is a little trickier than I thought. I had to run:
But then I get accurage coverage reports (modulo other Python versions, which are not important here). Anyway, CI is green now. |
Support generic classes for
has
andfields
.