-
-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete error signature of _InValidator #951
Commits on Apr 11, 2022
-
feat(ValueError of _InValidator): Add attr, options and value
The docstring of _in() says the ValueError would contain these, however it didn't. Adding said arguments enables uniform processing of ValueErrors raised by validators. One might for example want to extract the attr.name and the value that raised the error to show a custom, more user-friendly error message.
iron3oxide committedApr 11, 2022 Configuration menu - View commit details
-
Copy full SHA for 68bf50d - Browse repository at this point
Copy the full SHA 68bf50dView commit details -
test(tests for _InValidator): Adapt tests to new error signature
Since the error message isn't the only error argument anymore (but should still suffice to test functionality), it was necessary to only assert against the first argument.
iron3oxide committedApr 11, 2022 Configuration menu - View commit details
-
Copy full SHA for 470e654 - Browse repository at this point
Copy the full SHA 470e654View commit details -
test(tests for _InValidator): Redo tests properly
I thought I could get away with lazyness but it's better to do it the right way. The tests now check the full error signature.
iron3oxide committedApr 11, 2022 Configuration menu - View commit details
-
Copy full SHA for 33a3694 - Browse repository at this point
Copy the full SHA 33a3694View commit details -
docs(Changelog): Add changelog fragment
This should sufficiently summarize the changes.
iron3oxide committedApr 11, 2022 Configuration menu - View commit details
-
Copy full SHA for 9fcbee2 - Browse repository at this point
Copy the full SHA 9fcbee2View commit details -
[pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
Configuration menu - View commit details
-
Copy full SHA for 2f372b7 - Browse repository at this point
Copy the full SHA 2f372b7View commit details
Commits on Apr 12, 2022
-
feat(validators._in()): Add default argument "verbose_value_error=False"
This should allow for backwards-compatibility.
iron3oxide committedApr 12, 2022 Configuration menu - View commit details
-
Copy full SHA for 32cc097 - Browse repository at this point
Copy the full SHA 32cc097View commit details -
test(tests for _InValidator): Add tests for call with "verbose_value_…
…error=True" This should sufficiently test the verbose signature.
iron3oxide committedApr 12, 2022 Configuration menu - View commit details
-
Copy full SHA for 8a0d27e - Browse repository at this point
Copy the full SHA 8a0d27eView commit details -
docs(Changelog): Adapt changelog fragment
I noticed that the number didn't correspond to the PR #, so I renamed the file. Also modified the content to properly reflect the changes.
iron3oxide committedApr 12, 2022 Configuration menu - View commit details
-
Copy full SHA for 562eb51 - Browse repository at this point
Copy the full SHA 562eb51View commit details -
[pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
Configuration menu - View commit details
-
Copy full SHA for 1b6228a - Browse repository at this point
Copy the full SHA 1b6228aView commit details
Commits on May 2, 2022
-
docs(changelog fragment): Make fragment "breaking" and use semantic n…
…ewlines
iron3oxide committedMay 2, 2022 Configuration menu - View commit details
-
Copy full SHA for 4817aca - Browse repository at this point
Copy the full SHA 4817acaView commit details -
docs(docstring of _in()): Use semantic newlines
iron3oxide committedMay 2, 2022 Configuration menu - View commit details
-
Copy full SHA for d40b6e4 - Browse repository at this point
Copy the full SHA d40b6e4View commit details -
[pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
Configuration menu - View commit details
-
Copy full SHA for d7cfbd3 - Browse repository at this point
Copy the full SHA d7cfbd3View commit details
Commits on Jun 13, 2022
-
docs(changelog fragment): Use semantic newlines
iron3oxide committedJun 13, 2022 Configuration menu - View commit details
-
Copy full SHA for f6bb5c0 - Browse repository at this point
Copy the full SHA f6bb5c0View commit details -
Merge remote-tracking branch 'origin/main'
iron3oxide committedJun 13, 2022 Configuration menu - View commit details
-
Copy full SHA for c1cd68e - Browse repository at this point
Copy the full SHA c1cd68eView commit details -
Revert "[pre-commit.ci] auto fixes from pre-commit.com hooks"
This reverts commit d7cfbd3.
iron3oxide committedJun 13, 2022 Configuration menu - View commit details
-
Copy full SHA for a2c4f31 - Browse repository at this point
Copy the full SHA a2c4f31View commit details -
Revert "docs(docstring of _in()): Use semantic newlines"
This reverts commit d40b6e4.
iron3oxide committedJun 13, 2022 Configuration menu - View commit details
-
Copy full SHA for eb96ed2 - Browse repository at this point
Copy the full SHA eb96ed2View commit details -
revert(docs(changelog fragment)): Refix changelog fragment
iron3oxide committedJun 13, 2022 Configuration menu - View commit details
-
Copy full SHA for e09d2ca - Browse repository at this point
Copy the full SHA e09d2caView commit details -
Revert "[pre-commit.ci] auto fixes from pre-commit.com hooks"
This reverts commit 1b6228a
iron3oxide committedJun 13, 2022 Configuration menu - View commit details
-
Copy full SHA for 28cc8bc - Browse repository at this point
Copy the full SHA 28cc8bcView commit details -
Revert "docs(Changelog): Adapt changelog fragment"
This reverts commit 562eb51
iron3oxide committedJun 13, 2022 Configuration menu - View commit details
-
Copy full SHA for 26b4234 - Browse repository at this point
Copy the full SHA 26b4234View commit details -
Revert "test(tests for _InValidator): Add tests for call with "verbos…
…e_value_error=True"" This reverts commit 8a0d27e.
iron3oxide committedJun 13, 2022 Configuration menu - View commit details
-
Copy full SHA for c4131b5 - Browse repository at this point
Copy the full SHA c4131b5View commit details -
Revert "feat(validators._in()): Add default argument "verbose_value_e…
…rror=False"" This reverts commit 32cc097.
iron3oxide committedJun 13, 2022 Configuration menu - View commit details
-
Copy full SHA for 35ac759 - Browse repository at this point
Copy the full SHA 35ac759View commit details -
docs(changelog fragment): Remove old fragment that had the wrong name…
… and somehow reappeared during revert horror
iron3oxide committedJun 13, 2022 Configuration menu - View commit details
-
Copy full SHA for 67425fe - Browse repository at this point
Copy the full SHA 67425feView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3c5bfea - Browse repository at this point
Copy the full SHA 3c5bfeaView commit details