Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete error signature of _InValidator #951

Merged
merged 23 commits into from
Jun 13, 2022
Merged

Commits on Apr 11, 2022

  1. feat(ValueError of _InValidator): Add attr, options and value

    The docstring of _in() says the ValueError would contain these, however
    it didn't. Adding said arguments enables uniform processing of
    ValueErrors raised by validators. One might for example want to extract
    the attr.name and the value that raised the error to show a custom, more
    user-friendly error message.
    iron3oxide committed Apr 11, 2022
    Configuration menu
    Copy the full SHA
    68bf50d View commit details
    Browse the repository at this point in the history
  2. test(tests for _InValidator): Adapt tests to new error signature

    Since the error message isn't the only error argument anymore (but
    should still suffice to test functionality), it was necessary to only
    assert against the first argument.
    iron3oxide committed Apr 11, 2022
    Configuration menu
    Copy the full SHA
    470e654 View commit details
    Browse the repository at this point in the history
  3. test(tests for _InValidator): Redo tests properly

    I thought I could get away with lazyness but it's better to do it the
    right way. The tests now check the full error signature.
    iron3oxide committed Apr 11, 2022
    Configuration menu
    Copy the full SHA
    33a3694 View commit details
    Browse the repository at this point in the history
  4. docs(Changelog): Add changelog fragment

    This should sufficiently summarize the changes.
    iron3oxide committed Apr 11, 2022
    Configuration menu
    Copy the full SHA
    9fcbee2 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    2f372b7 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2022

  1. feat(validators._in()): Add default argument "verbose_value_error=False"

    This should allow for backwards-compatibility.
    iron3oxide committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    32cc097 View commit details
    Browse the repository at this point in the history
  2. test(tests for _InValidator): Add tests for call with "verbose_value_…

    …error=True"
    
    This should sufficiently test the verbose signature.
    iron3oxide committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    8a0d27e View commit details
    Browse the repository at this point in the history
  3. docs(Changelog): Adapt changelog fragment

    I noticed that the number didn't correspond to the PR #, so I renamed
    the file. Also modified the content to properly reflect the changes.
    iron3oxide committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    562eb51 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1b6228a View commit details
    Browse the repository at this point in the history

Commits on May 2, 2022

  1. docs(changelog fragment): Make fragment "breaking" and use semantic n…

    …ewlines
    iron3oxide committed May 2, 2022
    Configuration menu
    Copy the full SHA
    4817aca View commit details
    Browse the repository at this point in the history
  2. docs(docstring of _in()): Use semantic newlines

    iron3oxide committed May 2, 2022
    Configuration menu
    Copy the full SHA
    d40b6e4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d7cfbd3 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2022

  1. docs(changelog fragment): Use semantic newlines

    iron3oxide committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    f6bb5c0 View commit details
    Browse the repository at this point in the history
  2. Merge remote-tracking branch 'origin/main'

    iron3oxide committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    c1cd68e View commit details
    Browse the repository at this point in the history
  3. Revert "[pre-commit.ci] auto fixes from pre-commit.com hooks"

    This reverts commit d7cfbd3.
    iron3oxide committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    a2c4f31 View commit details
    Browse the repository at this point in the history
  4. Revert "docs(docstring of _in()): Use semantic newlines"

    This reverts commit d40b6e4.
    iron3oxide committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    eb96ed2 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e09d2ca View commit details
    Browse the repository at this point in the history
  6. Revert "[pre-commit.ci] auto fixes from pre-commit.com hooks"

    This reverts commit 1b6228a
    iron3oxide committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    28cc8bc View commit details
    Browse the repository at this point in the history
  7. Revert "docs(Changelog): Adapt changelog fragment"

    This reverts commit 562eb51
    iron3oxide committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    26b4234 View commit details
    Browse the repository at this point in the history
  8. Revert "test(tests for _InValidator): Add tests for call with "verbos…

    …e_value_error=True""
    
    This reverts commit 8a0d27e.
    iron3oxide committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    c4131b5 View commit details
    Browse the repository at this point in the history
  9. Revert "feat(validators._in()): Add default argument "verbose_value_e…

    …rror=False""
    
    This reverts commit 32cc097.
    iron3oxide committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    35ac759 View commit details
    Browse the repository at this point in the history
  10. docs(changelog fragment): Remove old fragment that had the wrong name…

    … and somehow reappeared during revert horror
    iron3oxide committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    67425fe View commit details
    Browse the repository at this point in the history
  11. Merge branch 'main' into main

    hynek authored Jun 13, 2022
    Configuration menu
    Copy the full SHA
    3c5bfea View commit details
    Browse the repository at this point in the history