You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I realized this just now in the course of discussing #451. The validation callback parses response data, which results in a download.
The fix will require re-thinking how retries are managed within the CacheDownloader.
It also reveals a gap between unit and acceptance testing, but I'll not worry about that at the moment.
The text was updated successfully, but these errors were encountered:
The right way to do this is to take the retries out of the streaming request helper and to put them into a broader context.
Basically, the validation callback should only fire if we have a cache miss. And if the validation callback fails, we start doing retries in a tight loop with the validation callback in order to avoid poisoning the cache with unparseable data.
I realized this just now in the course of discussing #451. The validation callback parses response data, which results in a download.
The fix will require re-thinking how retries are managed within the CacheDownloader.
It also reveals a gap between unit and acceptance testing, but I'll not worry about that at the moment.
The text was updated successfully, but these errors were encountered: