Relax ruff constraints to allow installing next to ruff 0.3.0 #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems to work fine on the new ruff 0.3.0 release
redeboer
reviewed
Feb 29, 2024
pyproject.toml
Outdated
| @@ -13,7 +13,7 @@ readme = "README.md" | |||
| requires-python = ">=3.8" | |||
| license = {text = "MIT"} | |||
| dependencies = [ | |||
| "ruff>=0.2.0, <0.3.0", | |||
| "ruff>=0.2.0, <0.4.0", | |||
There was a problem hiding this comment.
Is it an idea to remove the upper limit altogether? I think by now the burden of having to bump and release each time outweighs the risk of API changes.
There was a problem hiding this comment.
I had that thought as well, but it's pre 1.0 so there's no guarantee that there won't be breaking changes on minor version.
Either works for me though.
There was a problem hiding this comment.
I checked with ruff-lsp where there also is no upper constraint so I would be okay with that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems to work fine and unit tests all pass on the new ruff 0.3.0 release.