Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up unit tests #410

Closed
tkrabel-db opened this issue Aug 1, 2023 · 2 comments
Closed

Clean up unit tests #410

tkrabel-db opened this issue Aug 1, 2023 · 2 comments
Assignees
@tkrabel-db

Comments

@tkrabel-db
Copy link
Contributor

Follow up for #389. It makes sense cleaning up the unit tests in test_notebook_document.py and test_language_server.py, e.g. wrt shared objects.
CC @ccordoba12
@ccordoba12 ccordoba12 mentioned this issue Aug 9, 2023
Merged
@ccordoba12
Copy link
Member

ccordoba12 commented Aug 9, 2023 •
edited
Loading

Please try to address this after PR #389 is merged so we don't have the tests in those two files growing apart too much.

@tkrabel-db
Copy link
Contributor Author

Will do.

@tkrabel-db tkrabel-db mentioned this issue Aug 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tkrabel-db tkrabel-db

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ccordoba12 @tkrabel-db