Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.3.0 Release July 1, 2016 #1800

Closed
wiredfool opened this issue Apr 3, 2016 · 15 comments
Closed

3.3.0 Release July 1, 2016 #1800

wiredfool opened this issue Apr 3, 2016 · 15 comments
Labels
Milestone

Comments

@wiredfool
Copy link
Member

Tracking issue.

@radarhere
Copy link
Member

So, any remaining priorities for this release?

@wiredfool
Copy link
Member Author

wiredfool commented Jun 19, 2016

There's been a lot of C level changes in this iteration.

I really want to land the malloc check: pr #1781 .

#1934 is something that I think should land, but I'd like someone else to look at it and agree to the approach.

Something of the palette issue (#1593) should land, I think I'm leaning to the bytearray approach, but comments either way would be useful.

If I have time, I'd like to sweep though all of the numpy/fromarray issues and consolidate/resolve them. The ICC profile stuff is in that category too.

@homm
Copy link
Member

homm commented Jun 21, 2016

From my PR's I want to see in next release at least #1909 and #1970. Anything else is less important. Also, I want #1910 to be addressed, but I don't have a fix.

@wiredfool
Copy link
Member Author

I think we've hit all that.

@homm, what are your thoughts on bugfixes in #1986 and #1991?

The only other one that I'm considering at this point is #1846, which is just waiting on documentation. It's low risk, as it just adds behavior that was previously broken.

Apart from that, freeze except for docs.

@aclark4life
Copy link
Member

Thanks all for working on this release, let me know if you need anything! <3

@wiredfool
Copy link
Member Author

Release is tagged and source uploaded.

@wiredfool
Copy link
Member Author

@cgohlke Would appreciate windows binaries when you can.

@wiredfool
Copy link
Member Author

So, postmortem of sorts for this release. This feels like a big release, especially in terms of landing things in C land. Personally, I'm time constrained on reviews especially, so there are still a lot of PRs left.

As I see it, PRs fall into several categories;

  • Clearly no.
  • Eh, Suspicious without further input
  • Those needing tests or documentation
  • Those that are clearly 0 effect, and are for style.
  • Those that are possibly 0 effect, but take a close reading to make sure.
  • Bug fixes with tests
  • Small extensions of the api
  • Significant, but low risk.
  • Significant, high risk
  • Those that resemble flies from a distance

I think we've gotten most of the big ones into this release. There's a host in the needing more or possibly 0 effect categories.

@aclark4life
Copy link
Member

@cgohlke Probably time, though I'd hate to do that …

@wiredfool
Copy link
Member Author

There are a lot of files. I'm not clear on how many people would likely be impacted.

@wiredfool wiredfool reopened this Jul 1, 2016
@wiredfool
Copy link
Member Author

wiredfool commented Jul 1, 2016

49 binaries, 2 source packages. At least twine + pypi was uploading without 500 errors this time.

@hugovk
Copy link
Member

hugovk commented Jul 2, 2016

Pillow 3.2.0 download stats from PyPI using Vanity (assuming aclark4life/vanity#22 is fixed) show of 64,717 total downloads:

  • 359 egg
  • 467 exe
  • 6,947 whl
  • 54,608 zip
  • 2,336 tar.gz

In case there's some caching of stats; for 3.1.0 (inc. rc1), out of 452,851 total downloads there's a similar share:

  • 6,827 egg
  • 5,753 exe
  • 62,823 whl
  • 19,768 zip
  • 357,680 tar.gz
$ vanity pillow -p 3.2.0.*egg
    Pillow-3.2.0-py3.5-win32.egg    2016-04-01           35
Pillow-3.2.0-py3.5-win-amd64.egg    2016-04-01           22
    Pillow-3.2.0-py3.4-win32.egg    2016-04-01           44
Pillow-3.2.0-py3.4-win-amd64.egg    2016-04-01           17
    Pillow-3.2.0-py3.3-win32.egg    2016-04-01           13
Pillow-3.2.0-py3.3-win-amd64.egg    2016-04-01            9
    Pillow-3.2.0-py3.2-win32.egg    2016-04-01            9
Pillow-3.2.0-py3.2-win-amd64.egg    2016-04-01            9
    Pillow-3.2.0-py2.7-win32.egg    2016-04-01          134
Pillow-3.2.0-py2.7-win-amd64.egg    2016-04-01           44
    Pillow-3.2.0-py2.6-win32.egg    2016-04-01           12
Pillow-3.2.0-py2.6-win-amd64.egg    2016-04-01           11
-----------------------------------------------------------
Pillow has been downloaded 359 times!
$ vanity pillow -p 3.2.0.*exe
    Pillow-3.2.0.win32-py3.5.exe    2016-04-01           51
    Pillow-3.2.0.win32-py3.4.exe    2016-04-01           54
    Pillow-3.2.0.win32-py3.3.exe    2016-04-01            9
    Pillow-3.2.0.win32-py3.2.exe    2016-04-01           11
    Pillow-3.2.0.win32-py2.7.exe    2016-04-01           37
    Pillow-3.2.0.win32-py2.6.exe    2016-04-01            9
Pillow-3.2.0.win-amd64-py3.5.exe    2016-04-01          111
Pillow-3.2.0.win-amd64-py3.4.exe    2016-04-01           81
Pillow-3.2.0.win-amd64-py3.3.exe    2016-04-01           14
Pillow-3.2.0.win-amd64-py3.2.exe    2016-04-01            9
Pillow-3.2.0.win-amd64-py2.7.exe    2016-04-01           67
Pillow-3.2.0.win-amd64-py2.6.exe    2016-04-01           14
-----------------------------------------------------------
Pillow has been downloaded 467 times!
$ vanity pillow -p 3.2.0.*whl
                                                                                     Pillow-3.2.0-cp35-none-win_amd64.whl    2016-04-01          471
                                                                                         Pillow-3.2.0-cp35-none-win32.whl    2016-04-01          566
Pillow-3.2.0-cp35-cp35m-macosx_10_6_intel.macosx_10_9_intel.macosx_10_9_x86_64.macosx_10_10_intel.macosx_10_10_x86_64.whl    2016-04-01          753
                                                                                     Pillow-3.2.0-cp34-none-win_amd64.whl    2016-04-01          246
                                                                                         Pillow-3.2.0-cp34-none-win32.whl    2016-04-01          232
Pillow-3.2.0-cp34-cp34m-macosx_10_6_intel.macosx_10_9_intel.macosx_10_9_x86_64.macosx_10_10_intel.macosx_10_10_x86_64.whl    2016-04-01          159
                                                                                     Pillow-3.2.0-cp33-none-win_amd64.whl    2016-04-01           13
                                                                                         Pillow-3.2.0-cp33-none-win32.whl    2016-04-01           36
Pillow-3.2.0-cp33-cp33m-macosx_10_6_intel.macosx_10_9_intel.macosx_10_9_x86_64.macosx_10_10_intel.macosx_10_10_x86_64.whl    2016-04-01           12
                                                                                     Pillow-3.2.0-cp32-none-win_amd64.whl    2016-04-01            8
                                                                                         Pillow-3.2.0-cp32-none-win32.whl    2016-04-01           10
                                                                                     Pillow-3.2.0-cp27-none-win_amd64.whl    2016-04-01          773
                                                                                         Pillow-3.2.0-cp27-none-win32.whl    2016-04-01        1,308
Pillow-3.2.0-cp27-cp27m-macosx_10_6_intel.macosx_10_9_intel.macosx_10_9_x86_64.macosx_10_10_intel.macosx_10_10_x86_64.whl    2016-04-01        2,201
                                                                                     Pillow-3.2.0-cp26-none-win_amd64.whl    2016-04-01          102
                                                                                         Pillow-3.2.0-cp26-none-win32.whl    2016-04-01           57
----------------------------------------------------------------------------------------------------------------------------------------------------
Pillow has been downloaded 6,947 times!
$ vanity pillow -p 3.2.0.*zip
Pillow-3.2.0.zip    2016-04-01       54,608
-------------------------------------------
Pillow has been downloaded 54,608 times!
$ vanity pillow -p 3.2.0.*tar.gz
Pillow-3.2.0.tar.gz    2016-04-01        2,336
----------------------------------------------
Pillow has been downloaded 2,336 times!

@wiredfool
Copy link
Member Author

The difference between the 3.1 and 3.2 stats is somewhat unbelievable.

@aclark4life
Copy link
Member

aclark4life commented Jul 2, 2016

I think stats are still considered broken until warehouse aclark4life/vanity#22 (even if they've improved from "completely broken" to "still somewhat broken or unreliable")

@wiredfool
Copy link
Member Author

Thanks everyone! We'll be planning on doing this all again in 3 months...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants