Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle doesn't add all the internal packages #40

Closed
OceanManOne opened this issue Nov 26, 2022 · 2 comments
Closed

Bundle doesn't add all the internal packages #40

OceanManOne opened this issue Nov 26, 2022 · 2 comments

Comments

@OceanManOne
Copy link

Hi
I've encountered an issue where when using the plugin it does work with internal packages (packages I import as: lib1 = {path = "../../../poetry/lib1", develop = true} for example).

The issue is that when lib1 himself is importing another internal package, for example:
lib2 = {path = "../lib2", develop = true}

the output bundle doesn't contain lib2.
So it seems the plugin only works on the first level of internal packages, is it possible to add the ability to bundle all the project packages?

@neersighted
Copy link
Member

It's possible there's a bug here, I'd like to see a minimal reproducer so we can be sure you're not running into a docs issue/misusage (or was possibly solved by python-poetry/poetry-core#512). That being said, keep in mind that Poetry projects/Python packages are not trees. A path dependency doesn't leak more information than a PEP 508 marker (so, lib2 @ file://path/to/lib2), and we have not yet come up with a plan or decided on if we want to break that veil for 'monorepo' support.

In any case, please provide a reproduction so that we can figure out what is going on/what is expected.

@OceanManOne
Copy link
Author

I've retried it on a complete new setup and wasn't able to reproduce as everything seems to work as expected.

@neersighted neersighted closed this as not planned Won't fix, can't repro, duplicate, stale Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants