-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency of children not resolved when extras after version #1138
Comments
It seems to be working on my end. Could you provide a complete |
You are right! Trying to have a minimal example, I overshoot it. My latest comment on the order matters is incorrect. I updated my initial post. Sorry about that. Here is the pyproject.toml And here is the output of install -vvv |
Commit 426dbdc should fix the issue. The problem was the circular dependency between The fix will be available in the next bugfix release. |
Thank you very much for your super quick fix. |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
-vvv
option).dask = {version = "^1.2",extras = ["complete"]}
Issue
This issue is related to the way dask gets installed. The default pip command is
pip install dask
corresponds to "most common uses of Dask", to have the complete set dependency with pippip install dask[complete]
, this corresponds to a use case of the -E option as stated in this issueStep to reproduce the problem:
poetry add dask -E complete
--> new line in pyproject .tomldask = {version = "^1.2",extras = ["complete"]}
from dask.distributed import Client
This will fail on a missing tblib library.
pip install dask[complete]
, pip detects that tblib and psutil (among others) are not installed --> so the dependency resolution done by poetry was incompleteWhat is potentially happening:
Per [this file from Dask] (https://github.com/dask/dask/blob/a6abe3ca75179a7264a15de043335e6dbed684ea/setup.py#L10-L17) it appears that poetry does indeed find the first level dependency of
dask[complete]
but not the second level (dependencies of the dependencies).[edit: nope incorrect statement below]
Interestingly it seems that switching the order of version and extras in the pyproject.toml (fordask = {extras = ["complete"], version = "^1.2"}
does fix this issueThe text was updated successfully, but these errors were encountered: