Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support of manylinux2010 #1373

Closed
PgLoLo opened this issue Sep 13, 2019 · 7 comments
Closed

Support of manylinux2010 #1373

PgLoLo opened this issue Sep 13, 2019 · 7 comments
Labels
area/installer Related to the dependency installer kind/bug Something isn't working as expected

Comments

@PgLoLo
Copy link

PgLoLo commented Sep 13, 2019

  • OS version and name: Ubuntu 18.04
  • Poetry version: 0.12.17

Issue

As far, as I understand currently poetry incorrectly processes manylinux2010 dependency tag (which can be seen in this issue from TensorFlow project).

I am not sure, that problem is on the poetry side, but from the fact that PipEnv previously had this problem as well and does not have in recent versions, I conclude that that has to be solved in the poetry as well.

@PgLoLo
Copy link
Author

PgLoLo commented Sep 19, 2019

Currently, it is a very big restriction. Some libraries pretty much can not be installed with poetry.

@kasteph kasteph added kind/bug Something isn't working as expected area/installer Related to the dependency installer Hacktoberfest labels Sep 23, 2019
@sdispater
Copy link
Member

Like I said in this comment #1330 (comment) this is not on Poetry's end and it seems it has been fixed in tensorflow (see tensorflow/tensorflow#32758).

So the next release of tensorflow should work and have its dependencies properly specified.

@rbong
Copy link

rbong commented Nov 9, 2019

Isn't the Tensorflow fix just a workaround though?

According to this post pipenv was trying to install the MacOS version of Tensorflow since it didn't support manylinux2010 tags (PEP 571). Pipenv managed to fix it on their end by adding manylinux2010 support, see this comment to see that it's fixed on master.

Even though they are able to add a workaround on their end, the last official position still that this issue will be resolved by fixing it in poetry. See this comment.

So couldn't this happen with another package without adding support for manylinux2010 tags, or is poetry's issue different? Are there any plans to add manylinux2010 support, independent of whether the Tensorflow issue is fixed?

Sorry if I got something wrong, I just want to make sure I understand the position on manylinux2010 tags.

@SimonSelg
Copy link

Hey there,
this has indeed been fixed on tensorflows end, but only starting from 2.1rc0.
The same issue is present for tensorflow 1.15.0. Is there any workaround or plans to make tensorflow 1.15 work with poetry?

@kafendt
Copy link

kafendt commented Jan 20, 2020

Same problem here we depend on tensorflow 1.15.0 without this I guess I'll have to try pipenv instead :(

@leesei
Copy link

leesei commented Jan 21, 2020

Same problem here we depend on tensorflow 1.15.0 without this I guess I'll have to try pipenv instead :(

pipenv's latest build on PyPI faces the same issue.
But the master branch have it fixed (I haven't personally tested).

Copy link

github-actions bot commented Mar 3, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/installer Related to the dependency installer kind/bug Something isn't working as expected
Projects
None yet
Development

No branches or pull requests

7 participants