Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timer appears dark on dark terminal #2228

Closed
jtrakk opened this issue Mar 26, 2020 · 4 comments
Closed

Timer appears dark on dark terminal #2228

jtrakk opened this issue Mar 26, 2020 · 4 comments
Labels
area/cli Related to the command line

Comments

@jtrakk
Copy link
Contributor

jtrakk commented Mar 26, 2020

With a dark terminal background, the timer is hard to see.

image
@jtrakk jtrakk added the kind/bug Something isn't working as expected label Mar 26, 2020
@finswimmer finswimmer added area/cli Related to the command line and removed kind/bug Something isn't working as expected labels Mar 27, 2020
@bhaveshpraveen
Copy link

I'd like to work on this issue if no one's picked it up yet.

@abn
Copy link
Member

abn commented Apr 25, 2020

@bhaveshpraveen feel free to, but @sdispater might have some thoughts here. I'd suggest creating a draft PR if you have a solution to propose.

@bhaveshpraveen bhaveshpraveen mentioned this issue Apr 26, 2020
Closed
@sdispater
Copy link
Member

This issue was caused by the fact that we were using a black color in bold which could be too dark in some terminals and this has already been fixed in this PR: #2230.

This was already reported in #2150.

So I am closing this since it's already been handled.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 3, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area/cli Related to the command line
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Timer appears dark on dark terminal bhaveshpraveen/poetry
6 participants
@abn @sdispater @finswimmer @kasteph @bhaveshpraveen @jtrakk