Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use virtualenv 20.x #2420

Closed
2 tasks done
senpos opened this issue May 14, 2020 · 4 comments
Closed
2 tasks done

Always use virtualenv 20.x #2420

senpos opened this issue May 14, 2020 · 4 comments
Labels
kind/feature Feature requests/implementations

Comments

@senpos
Copy link

senpos commented May 14, 2020

  • I have searched the issues of this repo and believe that this is not a duplicate.
  • I have searched the documentation and believe that my question is not covered.

Feature Request

It is been a while, since virtualenv was completely rewritten.
The new version (20.x) and is a lot faster than both Python's built-in venv module and virtualenv 16.x.

It might be a good idea to always use new virtualenv 20.x in poetry.

At the moment, poetry uses virtualenv only for older Python versions.
In other cases, it uses venv.

I can see why Python may use an older and cut version of virtualenv in the standart library, it may be hard to maintain a bleeding-edge software.

But this change may add some value to such a modern dependency & enviroment management tool like poetry.

Would love to see poetry running even faster! :)

@senpos senpos added kind/feature Feature requests/implementations status/triage This issue needs to be triaged labels May 14, 2020
@finswimmer
Copy link
Member

Hello @senpos ,

can you imagine more benefits beside that the initial creation of a venv reduces from 2 to 0.2 seconds?

fin swimmer

@finswimmer finswimmer removed the status/triage This issue needs to be triaged label May 14, 2020
@pradyunsg
Copy link
Contributor

@finswimmer You can find more details in the original RFC for the virtualenv 20.0 rewrite: pypa/virtualenv#1366

@senpos
Copy link
Author

senpos commented Oct 7, 2020

Since #2666 is merged, should I close the issue? :)

@abn abn closed this as completed Oct 7, 2020
Copy link

github-actions bot commented Mar 2, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Feature requests/implementations
Projects
None yet
Development

No branches or pull requests

4 participants