Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PyPy 3.8 #4655

Closed
3 tasks done
rodrigodc opened this issue Oct 18, 2021 · 5 comments
Closed
3 tasks done

Support PyPy 3.8 #4655

rodrigodc opened this issue Oct 18, 2021 · 5 comments
Labels
kind/bug Something isn't working as expected

Comments

@rodrigodc
Copy link

rodrigodc commented Oct 18, 2021

Issue

Please update virtualenv when pypa/virtualenv#2206 gets merged.

Reason: virtualenvs created by Poetry are broken (not isolated) on PyPy 3.8, as described at pypa/virtualenv#2182.

A python3.8 dir is created in the venv (but remains empty, nothing is installed there) 👇

root@15e2c53df66a /tmp/test # ls <venv dir>/lib/python3.8/site-packages/

A pypy3.8 symlink is created pointing to the system (global) site-packages dir (and everything is installed there) 👇

root@15e2c53df66a /tmp/test # ls -latr <venv dir>/lib/pypy3.8
lrwxrwxrwx. 1 root root 28 Oct 18 18:12 <venv dir>/lib/pypy3.8 -> /usr/lib64/pypy3/lib/pypy3.8

The mentioned PR fixes that.

I can keep track of it and let you know when it gets merged and a new virtualenv version released with the fix.

Thank you,
Rodrigo

@rodrigodc rodrigodc added kind/bug Something isn't working as expected status/triage This issue needs to be triaged labels Oct 18, 2021
@rodrigodc
Copy link
Author

PR pypa/virtualenv#2206 has been merged.

@rodrigodc
Copy link
Author

virtualenv==20.9.0 is now available with the fix.

@rodrigodc
Copy link
Author

rodrigodc commented Nov 11, 2021

@sdispater, would it be possible to release 1.1.12 with the fixed virtualenv==20.9.0, as described above?

@mkniewallner
Copy link
Member

Hi, I believe this has since been fixed?

Even a fresh install of Poetry 1.1.11 will install virtualenv==20.15.1, in line with https://github.com/python-poetry/poetry/blob/1.1.11/pyproject.toml#L41

@mkniewallner mkniewallner added status/waiting-on-response Waiting on response from author and removed status/triage This issue needs to be triaged labels Jul 9, 2022
@mkniewallner mkniewallner removed the status/waiting-on-response Waiting on response from author label Jul 31, 2022
Copy link

github-actions bot commented Mar 1, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working as expected
Projects
None yet
Development

No branches or pull requests

2 participants