Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider retrying 500 errors on poetry install #7679

Closed
2 tasks done
novas0x2a opened this issue Mar 18, 2023 · 4 comments · Fixed by #7072
Closed
2 tasks done

consider retrying 500 errors on poetry install #7679

novas0x2a opened this issue Mar 18, 2023 · 4 comments · Fixed by #7072
Labels
kind/feature Feature requests/implementations status/triage This issue needs to be triaged

Comments

@novas0x2a
Copy link
Contributor

  • I have searched the issues of this repo and believe that this is not a duplicate.
  • I have searched the FAQ and general documentation and believe that my question is not already covered.

Feature Request

It's certainly perfectly normal to avoid retrying http 500s, but on the modern internet 500s tend to be extremely transient, so I was wondering if you'd consider permitting 500s to retry. It looks like, currently, the uploader retries 500--503, and the authenticator retries 502--504. Was this difference intentional?

There is actually a PR that aligns them, though it hasn't seen much attention, I think: #7072

@novas0x2a novas0x2a added kind/feature Feature requests/implementations status/triage This issue needs to be triaged labels Mar 18, 2023
@dimbleby
Copy link
Contributor

this is a duplicate of #7072, as you have pointed out yourself.

(I would agree that the backlog of PRs not getting attention is a sad thing: but I don't expect that duplicating PRs with issues will help)

@novas0x2a
Copy link
Contributor Author

Yeah, sorry, a lot of projects won't look at PRs unless there's an associated issue, wasn't sure if that was the case here.

@nejch
Copy link
Contributor

nejch commented Mar 28, 2023

Hey folks, I'm the author of that PR. I'll try to get to a windows machine so I can reproduce the Windows CI failures (or maybe rebasing will help already).

Maybe once the CI is green, it'll get more attention from maintainers. I'd be keen to get that merged of course as well :)

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Feature requests/implementations status/triage This issue needs to be triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants