--global-options Issue #845 Candidate

[reedjosh]

Pull Request Check List

• Added tests for changed code.
• Updated documentation for changed code.

Regarding:
Note: If your Pull Request introduces a new feature or changes the current behavior, it should be based
on the develop

If the methods used in this pull request are satisfactory, I will rebase upon the develop branch.

I added an argument to the add command and updated through to the schema and pip install.

I've personally used this code to install a package that wouldn't be possible otherwise. I added a test in the add command and ran the pre-commit hook.

I have not full addressed issue #845 as I did not provide --build-options or --install-options. If these are desired I can add them too, I just wanted to get feedback on my methods first.

Thank you!

[reedjosh]

Tests all fixed up. Please let me know your thoughts. I'm not certain the class usage model I've used jives with the intent of the objects. It does generate a nice readable toml file though.

pyodbc = {version = "4.0.26", global-options = ["build_ext", "--include-dirs", ".../joshuare/pkgs/include"]}

[clintlombard]

This would be super useful, for example installing tensorflow-graphics with GPU support requires passing a flag during installation. This fix would make it as simple as:

[tool.poetry.dependencies]
...
tensorflow-graphics-gpu = { git = "ssh://git@github.com:tensorflow/graphics.git", branch="master", global-option="--compute_platform gpu" }

[reedjosh]

@clintlombard Yup, we've been keeping a local copy of this branch at work until it gets merged. Haven't heard anything from the maintainers though. : /

I'm still happy to work this further once I do hear back.

[thrix]

I have not full addressed issue #845 as I did not provide --build-options or --install-options. If these are desired I can add them too, I just wanted to get feedback on my methods first.

Including them would be awesome, we now have to manually workaround this common problem on Fedora:

pycurl: libcurl link-time ssl backend (openssl) is different from compile-time ssl backend (none/other)

by manually reinstallaing the package in venv

[reedjosh]

@finswimmer Hey, I see people are still asking for this feature. Just bumping to see if you have time to review.

Thank you!

[jkklapp]

This PR needs to be merged in 🙏

[mvtm-dn]

I apologize, but does anybody work to merge this request?

[gjoseph92]

@reedjosh if this ever does get reviewed, here's a vote for --install-options; it would help me a lot. And here's a bump hoping this does get reviewed someday.

[ali5h]

another bump

[p-i-]

Including them would be awesome, we now have to manually workaround this common problem on Fedora:

pycurl: libcurl link-time ssl backend (openssl) is different from compile-time ssl backend (none/other)

by manually reinstallaing the package in venv

Bump! Are we nearly there yet? 🙈

[phyrwork]

Bumpity bump. What's left to be done here?

[mvtm-dn]

Bump

[toughrogrammer]

same here

[abn]

This is probably not the right level to solve this issue. For example --include-dirs might vary depending on the user environment. This is more an installation target environmet configuration rather than a dependency configuration. While there might be some configuration that makes sense for everyone, this might not be the case for all configurations. Additioanally, these configurations only apply if a bdist is not already available for the dependency.

Additionally, it is important to note that in a future poetry release pip usage for installing packages will be removed.

[neersighted]

Closing as pip is very much an internal implementation detail of Poetry these days, and we are moving to a custom installer and will drop our dependence on pip.

[dbischof90]

Closing as pip is very much an internal implementation detail of Poetry these days, and we are moving to a custom installer and will drop our dependence on pip.

As an addendum to this, do you have tracking issues for the development of the internal custom installer?

[neersighted]

#6205

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.