-
-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do you plan to http client? #236
Comments
If I understand the question correctly the response is (as far as I can tell) : you need to use https://github.com/njsmith/h11 or https://github.com/python-hyper/hyper-h2 depending on wether you want to speak http 1.1 or 2.0. h11 and h2 are sans-io implementation of the protocol, so you can use them with trio/curio/asyncio/choose-you-async-framework. I would look at #105 as it is stated here there are sill some work to do to support TLS before starting working on an http client. |
Building your own client out of h11 or h2 is not easy... they take care of the low-level bits of the HTTP protocol, but there's a lot more on top that a good client has to worry about. We don't plan to ship a http client as a built-in feature in the TLS support was implemented in #107, so it's available in current trio master and will be available in trio version 0.2, when I get around to releasing that... |
Closing this issue because I think it's answered, but if I'm wrong feel free to re-open. |
Earlier you suggested that urllib3 might be the best path to asynchronous http (#105). I am unfamiliar with asks but is it looking like a better path forward? I've also put in an issue with urllib3 trying to get a sense of where things stand (urllib3/urllib3#1228) regarding trio. I do think this issue may warrant a mention in the documentation (I almost created third issue before finding the other two). I realize trio is aimed at a lower level functionality but HTTP requests are likely the first thing a lot of folks will want to do with trio and your fame with h11 may lead to expectations that there is a clear way to tie them together :-) Even if there is no clear answer yet, a brief mention may reduce the number of extraneous issues raised. |
Basically :my impression is that |
No description provided.
The text was updated successfully, but these errors were encountered: