Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please make a new release #2655

Closed
mgorny opened this issue May 30, 2023 · 9 comments · Fixed by #2680
Closed

Please make a new release #2655

mgorny opened this issue May 30, 2023 · 9 comments · Fixed by #2680

Comments

@mgorny
Copy link
Contributor

mgorny commented May 30, 2023

Could you please make a new release? I'm specifically looking for the async_generator dependency being removed, as that should be good enough to enable Python 3.12 support in the Gentoo package.

@A5rocks
Copy link
Contributor

A5rocks commented May 30, 2023

Hi, I've been aiming for a release soon after 3.7 is no longer in our compatibility window (~a month), would that work?

Additionally, is async-generator really the only thing broken for 3.12? We have a bunch of test cases failing there, detailed in #2646. (Just checking if those matter!)

@mgorny
Copy link
Contributor Author

mgorny commented May 30, 2023

I've seen only 1 new test fail on Gentoo compared to Python 3.11 (trio/_core/_tests/test_run.py::test_nursery_cancel_doesnt_create_cyclic_garbage). I'm yet to see in greater detail but it seems good enough for httpx at a first glance.

I'm currently playing with a snapshot from current git, so hopefully that'll be good enough before the next release.

@bastimeyer
Copy link

Hi, would it be possible to publish a new release before waiting for the support end of Python 3.7? I don't care about 3.7, but the last release of trio was in September of last year, which is quite a while.

I'm specifically looking for support for generic typing of MemorySendChannel/MemoryReceiveChannel which was added in #2549 in February.

The most recent release of trio-typing already defines

class MemorySendChannel(trio.abc.SendChannel[T_contra]): ...
class MemoryReceiveChannel(trio.abc.ReceiveChannel[T_co]): ...

This just bit me a bit as a new user of trio, because I thought that this was supported. Right now I get this error when trying to implement generic memory channels:

TypeError: <class 'trio.MemorySendChannel'> is not a generic class

class EventListener(Generic[TEvent]):
    sender: trio.MemorySendChannel[TEvent]
    receiver: trio.MemoryReceiveChannel[TEvent]
    ...

Installing trio from git is not an option for me, so I'm kindly asking for a new release. Thanks!

@oremanj
Copy link
Member

oremanj commented Jun 12, 2023

3.7 EOL is in two weeks. I won't personally be able to roll a new release before that, but maybe someone else will.

You can use from __future__ import annotations to resolve the MemoryXyzChannel-not-generic error.

@jakkdl
Copy link
Member

jakkdl commented Jun 30, 2023

Are there any blockers / particular issues that should be merged before release @A5rocks?

@A5rocks
Copy link
Contributor

A5rocks commented Jun 30, 2023

Only #2674! merged

@A5rocks
Copy link
Contributor

A5rocks commented Jun 30, 2023

Oh yeah, and pylint failing on pypy-3.7 isn't great, since the required checks need to pass before releasing. I've left a comment on #2669 cause I think you could xfail it there or maybe you (or I) could make a seperate PR.

Fixed in #2676

@jakkdl
Copy link
Member

jakkdl commented Jul 3, 2023

🚀 🚀 🚀

@mgorny
Copy link
Contributor Author

mgorny commented Jul 3, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants