stale keyword on PR is stale

[iritkatriel]

Should the friendly bot remove the "stale" keyword when there is activity on a PR? See python/cpython#23427

[Mariatta]

We don't maintain the stale-bot. We may need to write our own GH action for it. 😕

I'm thinking it's ok to leave the stale label even after we add comment there, to indicate that this PR has been open for a while and hopefully we can continue paying attention to it until it gets closed.

I personally think it's useful to see how many stale PRs got closed/merged in the end. Keeping the stale label gives that sort of visibility.

[brettcannon]

I agree with @Mariatta and say we leave it as-is for a little while to see how it feels. If it ends up not feeling right then we can talk about what to do about it.

[hugovk]

This was likely a bug in https://github.com/actions/stale, now fixed: actions/stale#441.

This issue can be closed.

To confirm:

This PR python/cpython#29147 was marked as stale on 29 Nov 2021 UTC.

Some hours later a human left a comment.

On the next cron run on 30 Nov 2021 UTC, the stale label was removed.

Here's part of the log:

[#29147] Pull request #29147
  [#29147] Found this pull request last updated at: 2021-11-29T08:47:01Z
  [#29147] The option only-labels (​https://github.com/actions/stale#only-labels​) was not specified
  [#29147] └── Continuing the process for this pull request
  [#29147] Days before pull request stale: 30
  [#29147] The pull request is not closed nor locked. Trying to remove the close label...
  [#29147] ├── The close-pr-label (​https://github.com/actions/stale#close-pr-label​) option was not set
  [#29147] └── Skipping the removal of the close label
  [#29147] This pull request has a stale label
  [#29147] The option any-of-labels (​https://github.com/actions/stale#any-of-labels​) was not specified
  [#29147] └── Continuing the process for this pull request
  [#29147] This pull request has no milestone
  [#29147] └── Skip the milestones checks
  [#29147] This pull request has no assignee
  [#29147] └── Skip the assignees checks
  [#29147] This pull request is already stale
  [#29147] Checking for label on this pull request
  [#29147] Pull request marked stale on: 2021-11-29T00:06:19Z
  [#29147] Checking for comments on pull request since: 2021-11-29T00:06:19Z
  [#29147] Comments that are not the stale comment or another bot: 1
  [#29147] Pull request has been commented on: true
  [#29147] Days before pull request close: -1
  [#29147] Pull request has been updated: false
  [#29147] The option remove-stale-when-updated (​https://github.com/actions/stale#remove-stale-when-updated​) is: true
  [#29147] The stale label should not be removed
  [#29147] Remove the stale label since the pull request has a comment and the workflow should remove the stale label when updated
  [#29147] The pull request is no longer stale. Removing the stale label...
  [#29147] Removing the label "stale" from this pull request...
  [#29147] The label "stale" was removed
  [#29147] Skipping the process since the pull request is now un-stale
  [#29147] 2 operations consumed for this pull request

[iritkatriel]

Thanks.