From 1b10efad66e9a0b72aae82de23074eafa49ec4db Mon Sep 17 00:00:00 2001 From: Sam Gross Date: Thu, 11 Apr 2024 17:35:46 -0400 Subject: [PATCH] gh-117649: Fix file descriptor leak in (expected) failing test case (#117780) The test case is currently expected to fail in the free-threaded build. However, it fails before it gets a chance to close the write end of the pipe. --- Lib/test/test_capi/test_misc.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Lib/test/test_capi/test_misc.py b/Lib/test/test_capi/test_misc.py index 8cdecaf3626401..9c24ec8fd05b12 100644 --- a/Lib/test/test_capi/test_misc.py +++ b/Lib/test/test_capi/test_misc.py @@ -2139,6 +2139,9 @@ def check(enabled, override): } r, w = os.pipe() + if Py_GIL_DISABLED: + # gh-117649: The test fails before `w` is closed + self.addCleanup(os.close, w) script = textwrap.dedent(f''' from test.test_capi.check_config import run_singlephase_check run_singlephase_check({override}, {w})