-
-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some object-to-AST conversions are missing error checks #105588
Labels
3.11
only security fixes
3.12
bugs and security fixes
3.13
bugs and security fixes
interpreter-core
(Objects, Python, Grammar, and Parser dirs)
triaged
The issue has been accepted as valid by a triager.
type-crash
A hard crash of the interpreter, possibly with a core dump
Comments
brandtbucher
added
interpreter-core
(Objects, Python, Grammar, and Parser dirs)
3.11
only security fixes
type-crash
A hard crash of the interpreter, possibly with a core dump
3.12
bugs and security fixes
triaged
The issue has been accepted as valid by a triager.
3.13
bugs and security fixes
labels
Jun 9, 2023
brandtbucher
added a commit
that referenced
this issue
Jun 15, 2023
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this issue
Jun 15, 2023
pythonGH-105589) (cherry picked from commit a4056c8) Co-authored-by: Brandt Bucher <brandtbucher@microsoft.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this issue
Jun 15, 2023
pythonGH-105589) (cherry picked from commit a4056c8) Co-authored-by: Brandt Bucher <brandtbucher@microsoft.com>
brandtbucher
added a commit
that referenced
this issue
Jun 15, 2023
brandtbucher
added a commit
that referenced
this issue
Jun 15, 2023
carljm
added a commit
to carljm/cpython
that referenced
this issue
Jun 16, 2023
* main: pythongh-104799: PEP 695 backward compatibility for ast.unparse (python#105846) pythongh-105834: Add tests for calling `issubclass()` between two protocols (python#105835) CI: Remove docs build from Azure Pipelines (python#105823) pythongh-105844: Consistently use 'minor version' for X.Y versions (python#105851) Fix inaccuracies in "Assorted Topics" section of "Defining Extension Types" tutorial (python#104969) pythongh-105433: Add `pickle` tests for PEP695 (python#105443) bpo-44530: Document the change in MAKE_FUNCTION behavior (python#93189) pythonGH-103124: Multiline statement support for pdb (pythonGH-103125) pythonGH-105588: Add missing error checks to some obj2ast_* converters (pythonGH-105589)
gvanrossum
pushed a commit
to gvanrossum/cpython
that referenced
this issue
Jun 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3.11
only security fixes
3.12
bugs and security fixes
3.13
bugs and security fixes
interpreter-core
(Objects, Python, Grammar, and Parser dirs)
triaged
The issue has been accepted as valid by a triager.
type-crash
A hard crash of the interpreter, possibly with a core dump
The generated code in
Python-ast.c
is missing error checks following the construction of C-levelalias
,arg
,comprehension
,keyword
,match_item
, andwithitem
nodes from their Python object counterparts. This means it's possible to crash the interpreter by attempting to compile an AST where a required member of these nodes is replaced withNone
:I'll have a PR up in a minute with the one-line fix.
Linked PRs
obj2ast_*
converters #105589The text was updated successfully, but these errors were encountered: