Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pdb should check if the executing file is modified and warn users #111051

Closed
gaogaotiantian opened this issue Oct 19, 2023 · 2 comments
Closed

pdb should check if the executing file is modified and warn users #111051

gaogaotiantian opened this issue Oct 19, 2023 · 2 comments
Labels
stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@gaogaotiantian
Copy link
Member

gaogaotiantian commented Oct 19, 2023 •
edited by bedevere-app bot
Loading

Feature or enhancement

Proposal:

It's possible that the file is modified during debugging, which would definitely confuse users - the source will not match the execution anymore.

There's no perfect solution under such circunstances, but we should at least warn users that this is happening.

Has this already been discussed elsewhere?

This is a minor feature, which does not need previous discussion elsewhere

Links to previous discussion of this feature:

No response

Linked PRs
@gaogaotiantian gaogaotiantian added the type-feature A feature request or enhancement label Oct 19, 2023
@bedevere-app bedevere-app bot mentioned this issue Oct 19, 2023
Merged
@iritkatriel iritkatriel added the stdlib Python modules in the Lib dir label Nov 27, 2023
@gaogaotiantian gaogaotiantian mentioned this issue Dec 11, 2023
Closed
iritkatriel pushed a commit that referenced this issue Jan 25, 2024
@gaogaotiantian
gh-111051: Check if file is modifed during debugging in pdb (#111052)
8278fa2
aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
@gaogaotiantian @aisk
pythongh-111051: Check if file is modifed during debugging in pdb (p…
ea38356 
…ython#111052)
@ambv ambv reopened this Jul 18, 2024
@ambv
Copy link
Contributor

ambv commented Jul 18, 2024

I often have an issue with the test for this when running on a RAM disk formatted with HFS+. That file system only has 1-second mtime resolution, so the test often doesn't register an mtime change and intermittently fails. Fix incoming.

ambv added a commit to ambv/cpython that referenced this issue Jul 18, 2024
@ambv
pythongh-111051: [tests] Wait a second to support filesystems with lo…
332b073 
…w-resolution mtime
@bedevere-app bedevere-app bot mentioned this issue Jul 18, 2024
Merged
ambv added a commit to ambv/cpython that referenced this issue Jul 22, 2024
@ambv
Merge branch 'main' into pythongh-111051
a6a1d18
ambv added a commit that referenced this issue Jul 22, 2024
@ambv
gh-111051: [tests] Wait a second to support filesystems with low-reso…
cad11a2 
…lution mtime (GH-121959)
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 22, 2024
@ambv @miss-islington
pythongh-111051: [tests] Wait a second to support filesystems with lo…
af0ad6e 
…w-resolution mtime (pythonGH-121959)

(cherry picked from commit cad11a2)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
@bedevere-app bedevere-app bot mentioned this issue Jul 22, 2024
Merged
serhiy-storchaka pushed a commit that referenced this issue Aug 12, 2024
@miss-islington @ambv
[3.13] gh-111051: [tests] Wait a second to support filesystems with l…
8b64ce4 
…ow-resolution mtime (GH-121959) (GH-122114)

(cherry picked from commit cad11a2)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Glyphack pushed a commit to Glyphack/cpython that referenced this issue Sep 2, 2024
@gaogaotiantian @Glyphack
pythongh-111051: Check if file is modifed during debugging in pdb (p…
1960220 
…ython#111052)
@gaogaotiantian
Copy link
Member Author

Hi @ambv , is this fixed now? Can we close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stdlib Python modules in the Lib dir type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ambv @iritkatriel @gaogaotiantian