Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Availability of ptsname_r is not checked at runtime on macOS #123797

Closed
zanieb opened this issue Sep 6, 2024 · 3 comments
Closed

Availability of ptsname_r is not checked at runtime on macOS #123797

zanieb opened this issue Sep 6, 2024 · 3 comments
Assignees
@sobolevn
Labels
3.13 bugs and security fixes 3.14 new features, bugs and security fixes build The build process and cross-build OS-mac type-bug An unexpected behavior, bug, or error

Comments

@zanieb
Copy link

zanieb commented Sep 6, 2024 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

Use of this was recently added in Python 3.13 but it is only available in macOS 10.13.4+ and there is not a proper runtime check for availability. This means that in python-build-standalone we need to ban the symbol instead of allowing proper weak linking.

See discussion at indygreg/python-build-standalone#319 (comment)

Similar to #75782

CPython versions tested on:

3.13

Operating systems tested on:

macOS

Linked PRs
@zanieb zanieb added the type-bug An unexpected behavior, bug, or error label Sep 6, 2024
@zanieb
Copy link
Author

zanieb commented Sep 6, 2024 •
edited
Loading

This is a build issue but I can't make those.

edit: and thanks for fixing my typo

@zanieb zanieb mentioned this issue Sep 6, 2024
Merged
@JelleZijlstra JelleZijlstra added the build The build process and cross-build label Sep 6, 2024
@Eclips4 Eclips4 changed the title Availability of ptsrname_r is not checked at runtime on macOS Availability of ptsname_r is not checked at runtime on macOS Sep 6, 2024
@JelleZijlstra JelleZijlstra added the 3.13 bugs and security fixes label Sep 6, 2024
@picnixz picnixz added the OS-mac label Sep 6, 2024
sobolevn added a commit to sobolevn/cpython that referenced this issue Sep 7, 2024
@sobolevn
pythongh-123797: Check for runtime availability of ptsname_r on macos
6c0ec75
sobolevn added a commit to sobolevn/cpython that referenced this issue Sep 7, 2024
@sobolevn
pythongh-123797: Check for runtime availability of ptsname_r on macos
5be033a
@bedevere-app bedevere-app bot mentioned this issue Sep 7, 2024
Merged
sobolevn added a commit to sobolevn/cpython that referenced this issue Sep 7, 2024
@sobolevn
pythongh-123797: Check for runtime availability of ptsname_r on macos
9c7c710
@sobolevn sobolevn self-assigned this Sep 7, 2024
sobolevn added a commit to sobolevn/cpython that referenced this issue Sep 7, 2024
@sobolevn
pythongh-123797: Check for runtime availability of ptsname_r on macos
3008727
@Eclips4 Eclips4 added the 3.14 new features, bugs and security fixes label Sep 7, 2024
sobolevn added a commit that referenced this issue Sep 20, 2024
@sobolevn
gh-123797: Check for runtime availability of ptsname_r on macos (#1…
3e36e5a 
…23806)
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Sep 20, 2024
@sobolevn @miss-islington
pythongh-123797: Check for runtime availability of ptsname_r on mac…
1bdedd4 
…os (pythonGH-123806)

(cherry picked from commit 3e36e5a)

Co-authored-by: sobolevn <mail@sobolevn.me>
@bedevere-app bedevere-app bot mentioned this issue Sep 20, 2024
Merged
savannahostrowski pushed a commit to savannahostrowski/cpython that referenced this issue Sep 22, 2024
@sobolevn @savannahostrowski
pythongh-123797: Check for runtime availability of ptsname_r on mac…
c119ced 
…os (python#123806)
savannahostrowski pushed a commit to savannahostrowski/cpython that referenced this issue Sep 22, 2024
@sobolevn @savannahostrowski
pythongh-123797: Check for runtime availability of ptsname_r on mac…
dbf38b3 
…os (python#123806)
Yhg1s pushed a commit that referenced this issue Sep 30, 2024
@miss-islington @sobolevn
[3.13] gh-123797: Check for runtime availability of ptsname_r on ma…
dbfc37a 
…cos (GH-123806) (#124270)

gh-123797: Check for runtime availability of `ptsname_r` on macos (GH-123806)
(cherry picked from commit 3e36e5a)

Co-authored-by: sobolevn <mail@sobolevn.me>
@zanieb
Copy link
Author

zanieb commented Oct 9, 2024

I believe this was resolved?

@sobolevn
Copy link
Member

sobolevn commented Oct 9, 2024

Yes, thanks a lot, @zanieb, for the report! 👍

@sobolevn sobolevn closed this as completed Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sobolevn sobolevn

Labels
3.13 bugs and security fixes 3.14 new features, bugs and security fixes build The build process and cross-build OS-mac type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@JelleZijlstra @zanieb @sobolevn @picnixz @Eclips4