Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timing test too tight #63570

Closed
pitrou opened this issue Oct 23, 2013 · 2 comments
Closed

timing test too tight #63570

pitrou opened this issue Oct 23, 2013 · 2 comments
Labels
stdlib Python modules in the Lib dir tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@pitrou
Copy link
Member

pitrou commented Oct 23, 2013

BPO 19371
Nosy @gvanrossum, @pitrou, @ezio-melotti
Superseder
  • bpo-19579: test_asyncio: test__run_once timings should be relaxed
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2013-11-17.00:57:58.669>
    created_at = <Date 2013-10-23.22:20:01.745>
    labels = ['tests', 'type-bug', 'library']
    title = 'timing test too tight'
    updated_at = <Date 2013-11-17.00:57:58.669>
    user = 'https://github.com/pitrou'

    bugs.python.org fields:

    activity = <Date 2013-11-17.00:57:58.669>
    actor = 'ezio.melotti'
    assignee = 'none'
    closed = True
    closed_date = <Date 2013-11-17.00:57:58.669>
    closer = 'ezio.melotti'
    components = ['Library (Lib)', 'Tests']
    creation = <Date 2013-10-23.22:20:01.745>
    creator = 'pitrou'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 19371
    keywords = []
    message_count = 2.0
    messages = ['201077', '202717']
    nosy_count = 3.0
    nosy_names = ['gvanrossum', 'pitrou', 'ezio.melotti']
    pr_nums = []
    priority = 'normal'
    resolution = 'duplicate'
    stage = 'resolved'
    status = 'closed'
    superseder = '19579'
    type = 'behavior'
    url = 'https://bugs.python.org/issue19371'
    versions = ['Python 3.4']

    @pitrou
    Copy link
    Member Author

    pitrou commented Oct 23, 2013

    Looks like test_asyncio still has rather tight timing expectations:

    http://buildbot.python.org/all/builders/x86%20Windows%20Server%202008%20%5BSB%5D%203.x/builds/1495/steps/test/logs/stdio

    ======================================================================
    FAIL: test__run_once (test.test_asyncio.test_base_events.BaseEventLoopTests)
    ----------------------------------------------------------------------

    Traceback (most recent call last):
      File "E:\home\cpython\buildslave\x86\3.x.snakebite-win2k8r2sp1-x86\build\lib\test\test_asyncio\test_base_events.py", line 182, in test__run_once
        self.assertTrue(9.99 < t < 10.1, t)
    AssertionError: False is not true : 9.98499999998603

    @pitrou pitrou added stdlib Python modules in the Lib dir tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error labels Oct 23, 2013
    @ezio-melotti
    Copy link
    Member

    Also this should use assertAlmostEqual().

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    stdlib Python modules in the Lib dir tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants