Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tasklist test issue #97021

Closed
1 of 10 tasks
Tracked by #91420
ezio-melotti opened this issue Sep 22, 2022 · 8 comments
Closed
1 of 10 tasks
Tracked by #91420

Tasklist test issue #97021

ezio-melotti opened this issue Sep 22, 2022 · 8 comments

Comments

@ezio-melotti
Copy link
Member

ezio-melotti commented Sep 22, 2022

Tasks

Preview Give feedback
  1. 1 of 3
    tests
@ezio-melotti ezio-melotti changed the title tasklist test issue Tasklist test issue Sep 22, 2022
@CAM-Gerlach
Copy link
Member

I can't seem to "convert drafts to actual issues", including by clicking on the text or the button, so I'm not sure how that is supposed to work. Also, cross repo/org issues don't list the repo or org, so that's rather confusing. And without PRs (much less nested subissues, categories, etc. it doesn't perhaps seems as useful as I thought it would be—as I've used it and most often seen them used on Python-org repos, they are most commonly used to serve as a common issue for many relatively small/related PRs.

@ezio-melotti
Copy link
Member Author

I can't seem to "convert drafts to actual issues", including by clicking on the text or the button, so I'm not sure how that is supposed to work.

If you hover on a task a button with 3 dots should appear on the right. If you click on that and select "Convert to issue" it should create a new issue.
image

Also, cross repo/org issues don't list the repo or org, so that's rather confusing.

Indeed, I would expect zware/test#1 instead of just #1. FWIW if you hover on the issue you can see the repo in the popup that appears.

And without PRs

Apparently these are coming. I also reiterated the suggestion of providing a way to link PRs to issue that doesn't automatically close the issue when a PR is merged (see python/bedevere#501).

nested subissues, categories

IIUC the way to handle this is to create an issue A with a tasklist that includes B, and then add another tasklist in B. This doesn't currently show the nesting in A's tasklist though, but it might be added later, possibly together with other meta information.

cc @omerbensaadon

@CAM-Gerlach
Copy link
Member

If you hover on a task a button with 3 dots should appear on the right. If you click on that and select "Convert to issue" it should create a new issue.

I'm not seeing the three dots after I hover. Maybe it requires permissions I don't have as a triager (though I'm not sure why, and that would be fixed by my proposal)?

image

I also reiterated the suggestion of providing a way to link PRs to issue that doesn't automatically close the issue when a PR is merged (see python/bedevere#501).

That would indeed be very useful as we've discussed elsewhere (python/devguide#855 (comment)), and also replicate the old BPO functionality

IIUC the way to handle this is to create an issue A with a tasklist that includes B, and then add another tasklist in B.

I see; that's not ideal, but workable (I initially didn't include nested issues in #95913 myself)

@CAM-Gerlach
Copy link
Member

Seems like it is a permissions limitation, which I suppose in hindsight makes sense (since does modify the post source content) but may be surprising to users, and does tend to limit this feature's usability. However, the proposal in python/core-workflow#460 would work around that (as well as for existing Checklists).

@arhadthedev
Copy link
Member

The issue is no longer relevant. Bedevere settled down with the plain list. Here is gh-104584 as an example (note how verbose GitHub renders issue IDs inside list items):
So this issue can be closed.

So this issue can be closed.

@arhadthedev
Copy link
Member

Moreover, GitHub retires the format we experimented with:

To keep CPython issues working, I'm going through https://github.com/python/cpython/issues?q=tasklist replacing the tasklists with the new Bedevere format.

@arhadthedev
Copy link
Member

Done with careful rewriting and removal of misgenerated duplicates. Thus, closing this issue.

@arhadthedev arhadthedev closed this as not planned Won't fix, can't repro, duplicate, stale Jun 27, 2023
@ezio-melotti
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants