Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fix getstatus() -> getcode() typos #101296

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Jan 24, 2023

The docs say getstatus() for http.client.HTTPResponse and urllib.response.addinfourl:

But they're really getcode():

The documentation (and typos) for these were added as part of #11447 for Python 3.9 in 2019, although the methods have been around much longer (2009 and 2008).

Let's backport to at least 3.10.

Copy link
Contributor

@eamanu eamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hugovk hugovk merged commit 61f2be0 into python:main Feb 10, 2023
@hugovk hugovk deleted the fix-getstatus-getcode-typos branch February 10, 2023 18:46
@miss-islington
Copy link
Contributor

Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @hugovk, I had trouble checking out the 3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 61f2be08661949e2f6dfc94143436297e60d47de 3.11

@bedevere-bot
Copy link

GH-101804 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Feb 10, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 10, 2023
(cherry picked from commit 61f2be0)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@bedevere-bot
Copy link

GH-101805 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Feb 10, 2023
hugovk added a commit to hugovk/cpython that referenced this pull request Feb 10, 2023
carljm added a commit to carljm/cpython that referenced this pull request Feb 10, 2023
* main:
  Docs: Fix getstatus() -> getcode() typos (python#101296)
  Docs: use parameter list for sqlite3.Cursor.execute* (python#101782)
  pythongh-101763: Update bundled copy of libffi to 3.4.4 on Windows (pythonGH-101784)
  pythongh-101517: make bdb avoid looking up in linecache with lineno=None (python#101787)
  pythongh-101759: Update Windows installer to SQLite 3.40.1 (python#101762)
  pythongh-101277: Finalise isolating itertools (pythonGH-101305)
  pythongh-101759: Update macOS installer to SQLite 3.40.1 (python#101761)
miss-islington added a commit that referenced this pull request Feb 10, 2023
(cherry picked from commit 61f2be0)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants