-
-
Notifications
You must be signed in to change notification settings - Fork 30.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Fix getstatus() -> getcode() typos #101296
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
Sorry @hugovk, I had trouble checking out the |
GH-101804 is a backport of this pull request to the 3.10 branch. |
(cherry picked from commit 61f2be0) Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
GH-101805 is a backport of this pull request to the 3.11 branch. |
* main: Docs: Fix getstatus() -> getcode() typos (python#101296) Docs: use parameter list for sqlite3.Cursor.execute* (python#101782) pythongh-101763: Update bundled copy of libffi to 3.4.4 on Windows (pythonGH-101784) pythongh-101517: make bdb avoid looking up in linecache with lineno=None (python#101787) pythongh-101759: Update Windows installer to SQLite 3.40.1 (python#101762) pythongh-101277: Finalise isolating itertools (pythonGH-101305) pythongh-101759: Update macOS installer to SQLite 3.40.1 (python#101761)
(cherry picked from commit 61f2be0) Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
The docs say
getstatus()
forhttp.client.HTTPResponse
andurllib.response.addinfourl
:But they're really
getcode()
:cpython/Lib/http/client.py
Lines 778 to 783 in f02fa64
cpython/Lib/urllib/response.py
Lines 80 to 81 in f02fa64
The documentation (and typos) for these were added as part of #11447 for Python 3.9 in 2019, although the methods have been around much longer (2009 and 2008).
Let's backport to at least 3.10.