gh-101517: bdb should not lookup linecache with lineno=None #101787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iritkatriel
added
type-bug
kumaraditya303
approved these changes
Feb 10, 2023
|
Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
|
GH-101793 is a backport of this pull request to the 3.11 branch. |
|
GH-101794 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 10, 2023
…one (pythonGH-101787) (cherry picked from commit 366b949) Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 10, 2023
…one (pythonGH-101787) (cherry picked from commit 366b949) Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
miss-islington
added a commit
that referenced
this pull request
Feb 10, 2023
miss-islington
added a commit
that referenced
this pull request
Feb 10, 2023
carljm
added a commit
to carljm/cpython
that referenced
this pull request
Feb 10, 2023
* main: Docs: Fix getstatus() -> getcode() typos (python#101296) Docs: use parameter list for sqlite3.Cursor.execute* (python#101782) pythongh-101763: Update bundled copy of libffi to 3.4.4 on Windows (pythonGH-101784) pythongh-101517: make bdb avoid looking up in linecache with lineno=None (python#101787) pythongh-101759: Update Windows installer to SQLite 3.40.1 (python#101762) pythongh-101277: Finalise isolating itertools (pythonGH-101305) pythongh-101759: Update macOS installer to SQLite 3.40.1 (python#101761)
iritkatriel
added a commit
to iritkatriel/cpython
that referenced
this pull request
Mar 17, 2023
…lineno=None (python#101787)" This reverts commit 366b949.
iritkatriel
added a commit
to iritkatriel/cpython
that referenced
this pull request
Mar 18, 2023
…lineno=None (python#101787)" This reverts commit 366b949.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root cause of gh-101517 is that the line number was missing in the bytecode, but pdb should not have failed the way it did.
This PR makes bdb check that the lineno is not None before looking it up in the linecache.