Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-93649: Split exception tests from _testcapimodule.c #102173

Merged
merged 4 commits into from
Feb 23, 2023

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Feb 23, 2023

Automerge-Triggered-By: GH:erlend-aasland

@erlend-aasland
Copy link
Contributor Author

Rationale: make it easier to increase coverage of the C API for exception handling.

Regarding the Lib/test part: the _testcapi stuff is scattered across a lot of test files. Would it make sense to consolidate these (in a follow-up PR)?

@iritkatriel
Copy link
Member

Rationale: make it easier to increase coverage of the C API for exception handling.

Regarding the Lib/test part: the _testcapi stuff is scattered across a lot of test files. Would it make sense to consolidate these (in a follow-up PR)?

It depends, we'd need to see why it's scattered like that. Could be divided on some other criteria.

@miss-islington
Copy link
Contributor

@erlend-aasland: Status check is done, and it's a failure or timed out ❌.

@miss-islington
Copy link
Contributor

@erlend-aasland: Status check is done, and it's a failure or timed out ❌.

@miss-islington
Copy link
Contributor

Status check is done, and it's a success ✅.

@miss-islington miss-islington merged commit efc985a into python:main Feb 23, 2023
@erlend-aasland erlend-aasland deleted the split-testcapi/exceptions branch February 23, 2023 17:12
JelleZijlstra pushed a commit to JelleZijlstra/cpython that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants