-
-
Notifications
You must be signed in to change notification settings - Fork 30.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-103484: Fix redirected permanently URLs #104001
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com> Co-authored-by: Oleg Iarygin <dralife@yandex.ru>
I have made the requested changes; please review again |
Thanks for making the requested changes! @hugovk: please review the changes made to this pull request. |
@rffontenelle Thanks again! Please could you create the 3.11 backport PR? |
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com> Co-authored-by: Oleg Iarygin <dralife@yandex.ru> (cherry picked from commit 68ed2a2)
GH-104088 is a backport of this pull request to the 3.11 branch. |
* main: pythongh-103822: [Calendar] change return value to enum for day and month APIs (pythonGH-103827) pythongh-65022: Fix description of tuple return value in copyreg (python#103892) pythonGH-103525: Improve exception message from `pathlib.PurePath()` (pythonGH-103526) pythongh-84436: Add integration C API tests for immortal objects (pythongh-103962) pythongh-103743: Add PyUnstable_Object_GC_NewWithExtraData (pythonGH-103744) pythongh-102997: Update Windows installer to SQLite 3.41.2. (python#102999) pythonGH-103484: Fix redirected permanently URLs (python#104001) Improve assert_type phrasing (python#104081) pythongh-102997: Update macOS installer to SQLite 3.41.2. (pythonGH-102998) pythonGH-103472: close response in HTTPConnection._tunnel (python#103473) pythongh-88496: IDLE - fix another test on macOS (python#104075) pythongh-94673: Hide Objects in PyTypeObject Behind Accessors (pythongh-104074) pythongh-94673: Properly Initialize and Finalize Static Builtin Types for Each Interpreter (pythongh-104072) pythongh-104016: Skip test for deeply neste f-strings on wasi (python#104071)
* main: (760 commits) pythonGH-104102: Optimize `pathlib.Path.glob()` handling of `../` pattern segments (pythonGH-104103) pythonGH-104104: Optimize `pathlib.Path.glob()` by avoiding repeated calls to `os.path.normcase()` (pythonGH-104105) pythongh-103822: [Calendar] change return value to enum for day and month APIs (pythonGH-103827) pythongh-65022: Fix description of tuple return value in copyreg (python#103892) pythonGH-103525: Improve exception message from `pathlib.PurePath()` (pythonGH-103526) pythongh-84436: Add integration C API tests for immortal objects (pythongh-103962) pythongh-103743: Add PyUnstable_Object_GC_NewWithExtraData (pythonGH-103744) pythongh-102997: Update Windows installer to SQLite 3.41.2. (python#102999) pythonGH-103484: Fix redirected permanently URLs (python#104001) Improve assert_type phrasing (python#104081) pythongh-102997: Update macOS installer to SQLite 3.41.2. (pythonGH-102998) pythonGH-103472: close response in HTTPConnection._tunnel (python#103473) pythongh-88496: IDLE - fix another test on macOS (python#104075) pythongh-94673: Hide Objects in PyTypeObject Behind Accessors (pythongh-104074) pythongh-94673: Properly Initialize and Finalize Static Builtin Types for Each Interpreter (pythongh-104072) pythongh-104016: Skip test for deeply neste f-strings on wasi (python#104071) pythongh-104057: Fix direct invocation of test_super (python#104064) pythongh-87092: Expose assembler to unit tests (python#103988) pythongh-97696: asyncio eager tasks factory (python#102853) pythongh-84436: Immortalize in _PyStructSequence_InitBuiltinWithFlags() (pythongh-104054) ...
This is another patch required to fix the current state of
make linkcheck
in Python Docs.This pull request fixes occurrences of "redirected permanently" as reported by make linkcheck. The last one is "redirected with Found", which I plan to present after this one.
See the full output containing redirected permanently.
Note on backporting to 3.11:
I collapsed the contents of this message to reduce the size of the original message and make easier to reach the comments.
Content no longer available
I used wayback machine because the current website is not available anymore, or its current content does not reflect the contents from that time (e.g. visual studio was meant to be version 2015, which surely is different from today's).
Redirecting to new domain
Simply updated the domain.
http to https
"http://www.python.org": kept as is and added to allowed redirects because its use was intentional in the doc (Misc/NEWS.d/3.5.0a1.rst)
The rest of them I simply replaced with the redirect.
Subdomain changed (www, ww2, man)
Simply replaced with the redirect.
App name changed
Simply replaced with the redirect.
Microsoft redirecting to learn.microsoft.com
The above lines are just examples. The output file shows several occurrences of these three redirects. I felt it would be better to use allowed redirect instead of replacing it for both reducing the commit lines and to keep history.
These websites' well-known URLs redirect to their English versions. I added allowed redirect because felt using the URL without language looks cleaner.Redirecting to English version
IETF URLs: I changed to the new one, as Tools website was decommissioned (as per authors.ietf.org, redirected from tools.ietf.org)Redirecting to proper landing page
PSF License: I replaced with the redirected link and updated the text, there is no PSF license page linking to the full text of the license — it all goes to license page in Python's documentation
The rest of them I included to the allowed redirects because I felt they seemed better as they are now.
Redirecting to new structure in the website
boost: added to allowed redirect because the URL is used without mentioning specific version, so linking to boost 1.82 could not be as expected by the author. There is no "latest" URL -- I mean, it exists but redirects to the latest released version, 1.82 as of this PR.
support.microsoft.com: added to allowed redirect because it seems cleaner and more future proof than the redirected URL.
SICP: added to allowed redirect because the URL is not a hyperlink with other text, so replacing the redirected URL would look weird and huge.
activestate recipes: adding '/' to the end of the URL solved the redirect reported.
activetcl: The text refers to a specific old version, so I used wayback machine.
The rest of them I replaced with the redirect.