Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-106152: Add PY_THROW event to cProfile #106161

Merged
merged 2 commits into from
Jun 29, 2023
Merged

gh-106152: Add PY_THROW event to cProfile #106161

merged 2 commits into from
Jun 29, 2023

Conversation

gaogaotiantian
Copy link
Member

@gaogaotiantian gaogaotiantian commented Jun 27, 2023 •
edited by bedevere-bot
Loading

PY_MONITORING_EVENT_PY_THROW is missing which caused incorrect profiling for generators that are garbage collected(and maybe in other cases).

@gaogaotiantian gaogaotiantian added the needs backport to 3.12 bug and security fixes label Jun 27, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 27, 2023
Closed
@brandtbucher brandtbucher added type-bug An unexpected behavior, bug, or error extension-modules C modules in the Modules dir labels Jun 29, 2023
@brandtbucher
Copy link
Member

Looks good, thanks @gaogaotiantian!

@brandtbucher brandtbucher merged commit cea9d4e into python:main Jun 29, 2023
@miss-islington
Copy link
Contributor

Thanks @gaogaotiantian for the PR, and @brandtbucher for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

GH-106256 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label Jun 29, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 29, 2023
@gaogaotiantian @miss-islington
pythonGH-106152: Add PY_THROW event to cProfile (pythonGH-106161)
f80e76b 
(cherry picked from commit cea9d4e)

Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>
@gaogaotiantian gaogaotiantian deleted the fix-cprofile-throw branch June 29, 2023 23:16
brandtbucher pushed a commit that referenced this pull request Jun 29, 2023
@miss-islington @gaogaotiantian
[3.12] GH-106152: Add PY_THROW event to cProfile (GH-106256)
04a165f 
GH-106152: Add PY_THROW event to cProfile (GH-106161)
(cherry picked from commit cea9d4e)

Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>
@gaogaotiantian gaogaotiantian mentioned this pull request Oct 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandtbucher brandtbucher Awaiting requested review from brandtbucher

Assignees
No one assigned
Labels
extension-modules C modules in the Modules dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gaogaotiantian @brandtbucher @miss-islington @bedevere-bot