Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-106432: Added WSL support for adjusting the local hostname #106432

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Ineffable22
Copy link

@Ineffable22 Ineffable22 commented Jul 4, 2023

gh-106432: Added WSL support for adjusting the local hostname in smtplib.

This pull request introduces a new functionality to the smtplib library that enables it to detect and handle the Windows Subsystem for Linux (WSL) environment. The main change is the adjustment of the local hostname to ensure compatibility and proper functionality within WSL.

The changes include:

  • Addition of code to detect if the environment is WSL and modify the local hostname accordingly
  • Documentation updates explaining the purpose, context, and impact of the code
  • Clear explanations of the code logic and benefits

These changes enhance the usability and compatibility of smtplib when used within WSL, allowing developers to send emails from applications running on WSL without issues related to the local hostname. The modifications align with the existing codebase and follow the established contribution guidelines.

Please review these changes and consider merging them into the main repository. Thank you!

@Ineffable22 Ineffable22 requested a review from a team as a code owner July 4, 2023 19:31
@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@cpython-cla-bot
Copy link

cpython-cla-bot bot commented Jul 4, 2023

All commit authors signed the Contributor License Agreement.
CLA signed

@Ineffable22 Ineffable22 changed the title gh-106425: Added WSL support for adjusting the local hostname gh-106432: Added WSL support for adjusting the local hostname Jul 4, 2023
@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants