-
-
Notifications
You must be signed in to change notification settings - Fork 30.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-119462: Enforce invariants of type versioning #120731
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few questions.
Misc/NEWS.d/next/Core and Builtins/2024-06-19-11-10-50.gh-issue-119462.DpcqSe.rst
Outdated
Show resolved
Hide resolved
Fidget-Spinner
approved these changes
Jun 19, 2024
markshannon
added
needs backport to 3.8
needs backport to 3.13
bugs and security fixes
labels
Jun 19, 2024
Thanks @markshannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Sorry, @markshannon, I could not cleanly backport this to
|
markshannon
added a commit
to faster-cpython/cpython
that referenced
this pull request
Jun 19, 2024
* Remove uses of Py_TPFLAGS_VALID_VERSION_TAG
markshannon
added a commit
that referenced
this pull request
Jun 20, 2024
mrahtz
pushed a commit
to mrahtz/cpython
that referenced
this pull request
Jun 30, 2024
* Remove uses of Py_TPFLAGS_VALID_VERSION_TAG
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
* Remove uses of Py_TPFLAGS_VALID_VERSION_TAG
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
* Remove uses of Py_TPFLAGS_VALID_VERSION_TAG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enforces the following invariants:
1 is required for correct functioning of the method cache and is an explicitly documented requirement.
2 and 3 are necessary for correct operation of the specializing interpreter.