Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-89083: small docs fixup for UUIDv8 #126857

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

picnixz
Copy link
Contributor

@picnixz picnixz commented Nov 15, 2024

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting review labels Nov 15, 2024
@picnixz picnixz removed docs Documentation in the Doc dir awaiting review labels Nov 15, 2024
@picnixz picnixz requested a review from hugovk November 15, 2024 09:01
@hugovk hugovk merged commit e174869 into python:main Nov 15, 2024
36 checks passed
@hugovk
Copy link
Member

hugovk commented Nov 15, 2024

Thanks!

@picnixz picnixz deleted the docs/fixp-uuid-v8-89083 branch November 15, 2024 12:52
@picnixz
Copy link
Contributor Author

picnixz commented Nov 15, 2024

Oh, I actually used a versionadded. It does not really matter here but semantically speaking, maybe a versionchanged would have been better? I used that directive in the v6 and v8 PRs but let's not change it in a follow-up commit (it's not really an issue).

@hugovk
Copy link
Member

hugovk commented Nov 15, 2024

In that we're adding uuid8() and changing the CLI to support version 8?

We could also say we're adding uuid8() and adding version 8 to the CLI. I don't mind too much either way :)

@picnixz
Copy link
Contributor Author

picnixz commented Nov 15, 2024

In that we're adding uuid8() and changing the CLI to support version 8?

Yes. In addition, our convention seems to the "changed in version XXX" when we add new parameters or if there's already a versionadded for the object being documented (in this case the CLI program).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants