Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-38693: Prefer f-strings in importlib.resources (importlib_resources 5.0.6). #26387

Merged
merged 1 commit into from
May 26, 2021
Merged

bpo-38693: Prefer f-strings in importlib.resources (importlib_resources 5.0.6). #26387

merged 1 commit into from
May 26, 2021

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented May 26, 2021 •
edited
Loading

https://bugs.python.org/issue38693

Automerge-Triggered-By: GH:jaraco

@jaraco
Copy link
Member Author

jaraco commented May 26, 2021

bpo link is wrong

@jaraco jaraco force-pushed the bpo-38693/importlib-resources-fstrings branch from 9989c18 to 17012d9 Compare May 26, 2021 19:53
@jaraco jaraco changed the title bpo-33693: Prefer f-strings in importlib.resources (importlib_resources 5.0.6). bpo-38693: Prefer f-strings in importlib.resources (importlib_resources 5.0.6). May 26, 2021
@jaraco jaraco requested a review from gpshead May 26, 2021 20:00
ericvsmith
ericvsmith approved these changes May 26, 2021
View reviewed changes
Copy link
Member

@ericvsmith ericvsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@miss-islington
Copy link
Contributor

@jaraco: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit f6fbdb9 into main May 26, 2021
@miss-islington miss-islington deleted the bpo-38693/importlib-resources-fstrings branch May 26, 2021 20:16
@miss-islington
Copy link
Contributor

Thanks @jaraco for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 26, 2021
@jaraco @miss-islington
bpo-38693: Prefer f-strings in importlib.resources (importlib_resourc…
5e9af53 
…es 5.0.6). (pythonGH-26387)

Automerge-Triggered-By: GH:jaraco
(cherry picked from commit f6fbdb9)

Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
@bedevere-bot
Copy link

GH-26389 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label May 26, 2021
jaraco added a commit that referenced this pull request May 26, 2021
@miss-islington @jaraco
bpo-38693: Prefer f-strings in importlib.resources (importlib_resourc…
97b4576 
…es 5.0.6). (GH-26387) (#26389)

Automerge-Triggered-By: GH:jaraco
(cherry picked from commit f6fbdb9)

Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>

Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
@gpshead gpshead mentioned this pull request May 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericvsmith ericvsmith ericvsmith approved these changes

@gpshead gpshead Awaiting requested review from gpshead

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jaraco @miss-islington @bedevere-bot @ericvsmith @the-knights-who-say-ni