bpo-31715 Add mimetype for extension .mjs

[bmeck]

see https://bugs.python.org/issue31715

https://bugs.python.org/issue31715

[the-knights-who-say-ni]

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

[MylesBorins]

The CLA has now been signed, is there anything blocking this?

[Mariatta]

Needs review from @python/email-team and news entry.

[MylesBorins]

Thanks @Mariatta

I've send @bmeck a PR that includes the news entry in bmeck@f54e12c

Does it look like I did that correctly?

[Mariatta]

@MylesBorins The news entry lgtm. If @bmeck ended up accepting your PR, then you should sign Python's CLA too.

And we'll need to make sure to add Co-authored by: in the commit message of this PR. (The committer will do this).

[MylesBorins]

thanks @Mariatta I've privately communicated with @bmeck to coordinate... signed the CLA... and look forward to the review.

[the-knights-who-say-ni]

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

[MylesBorins]

CLA is confirmed if you want to re-run commit bot

[MylesBorins]

here's an example of this biting people in the wild

https://twitter.com/kuvos/status/1046984084575150082

Anyway we could get review on this?

[emilyemorehouse]

I'll leave the argument to someone more familiar with RFC details on mimetypes (there are 3+ RFCs on this), but I think we should maintain consistency between our support of .js and .mjs files.

Currently, .js files are application/javascript, but this proposes to add .mjs as text/javascript, which is seemingly obsolete for modern browsers.

@MylesBorins or @bmeck, do you see a reason to support text/javascript instead of application/javascript?

[bmeck]

@emilyemorehouse per the up to date HTML standard text/javascript is the proper response to send to browsers https://html.spec.whatwg.org/multipage/scripting.html#scriptingLanguages:javascript-mime-type

[emilyemorehouse]

Sounds good, I'd make the argument that both should use text/javascript then. I'll keep an eye on this if you don't get a response from the email team code owners soon.

[MylesBorins]

I've opened #9678 and https://bugs.python.org/issue34875 to update the mimetype of .js

[asvetlov]

It should be application/javascript for consistency with .js

[mathiasbynens]

text/javascript is correct, and .js should be changed to use it as well. Please see the discussion above. #3908 (comment)

[ammaraskar]

asveltov's rationale for application/javascript is explained here: https://bugs.python.org/issue34875

[mathiasbynens]

Would you be open to adding .mjs support with application/javascript until https://datatracker.ietf.org/doc/draft-ietf-dispatch-javascript-mjs/ gets officially accepted? It would be better to have some support than to have none at all, given that people are already running into issues with SimpleHTTPServer.

Note that Google Chrome already explicitly supports mjs: https://chromium-review.googlesource.com/c/chromium/src/+/1117070 (with text/javascript)

[mathiasbynens]

Re-reading this, it sounds like you are open to that. That’s great! I look forward to Python supporting mjs, and eventually serving it as text/javascript.

[bmeck]

I have made the requested changes; please review again.

[bedevere-bot]

Thanks for making the requested changes!

@asvetlov: please review the changes made to this pull request.

[ljharb]

Associate

[bedevere-bot]

@asvetlov: Please replace # with GH- in the commit message next time. Thanks!