-
-
Notifications
You must be signed in to change notification settings - Fork 30.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-29481: DOC: mark which version typing.Deque added #61
Conversation
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA. This is necessary for legal reasons before we can look at your contribution. Please follow these steps to help rectify the issue:
Thanks again to your contribution and we look forward to looking at it! |
Codecov Report
@@ Coverage Diff @@
## master #61 +/- ##
==========================================
+ Coverage 82.37% 82.37% +<.01%
==========================================
Files 1427 1427
Lines 350948 350948
==========================================
+ Hits 289091 289095 +4
+ Misses 61857 61853 -4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've re-targeted this to master branch. We can then backport this to 3.6. For 3.5, we'll need a separate PR that adds .. versionadded:: 3.5.4
.
Doc/library/typing.rst
Outdated
@@ -574,6 +574,9 @@ The module defines the following classes, functions and decorators: | |||
|
|||
A generic version of :class:`collections.deque`. | |||
|
|||
.. versionadded:: 3.5.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For 3.6 docs, we can remove .. versionadded:: 3.5.4
.
Should the 3.5 one also target master? |
86b0fa5
to
5dd1ab0
Compare
fixed and force-pushed. I am currently running the CLA by my employer, it may be faster to just have someone else do this (given how minor it is). |
3.5 should be against 3.5 branch, but don't worry about that :) Core developers can do the 3.5 backport. |
Closing as this can be fixed faster by others than I expect to be able to sign the CLA. |
Backport fix for test isolation from Python 3.8/3.7 Closes python#61 See merge request python-devs/importlib_resources!63
This is targeted at 3.6, but half of it should be backported to 3.5.