Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-82874: Use f-strings instead of str.format within importlib.__init__.py #94016

Closed
wants to merge 2 commits into from

Conversation

achhina
Copy link
Contributor

@achhina achhina commented Jun 20, 2022

Continuation of GH-82874 for importlib.__init__.py.

@methane
Copy link
Member

methane commented Jul 22, 2023

Closing this because massive conflicts and importlib/__init__.py already uses f-string.

@achhina
Copy link
Contributor Author

achhina commented Jul 22, 2023

Closing this because massive conflicts and importlib/__init__.py already uses f-string.

Ah yes, forgot this was still open, thank you for noticing and closing this. At the time I opened this PR, there weren't any conflicts and importlib's init had not yet fully used f-strings, but I suppose another PR must have addressed that since then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants