-
-
Notifications
You must be signed in to change notification settings - Fork 30.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-98940: Fix Mac/Extras.install.py File filter bug #98943
gh-98940: Fix Mac/Extras.install.py File filter bug #98943
Conversation
Misc/NEWS.d/next/macOS/2022-11-01-10-32-23.gh-issue-98940.W3YzC_.rst
Outdated
Show resolved
Hide resolved
…C_.rst fix news.d Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Sorry, you need @python/macos-team for this, not me. |
Oh, sorry. You are from Windows team :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Patch looks good to me.
Thanks @zhangbo2012 for the PR, and @ronaldoussoren for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
GH-99528 is a backport of this pull request to the 3.11 branch. |
|
I've fixed this |
gh-98940: Fix Mac/Extras.install.py Can not filter osx .DS_store file
Mac/Extras.install.py,Can not filter osx DS_store file
As
But in OSX, Real File Name is
.DS_Store
, like this(venv) zhangbo@zhangbodeMacBook-Pro a2 % ll -a total 16 drwxr-xr-x 4 zhangbo staff 128 Oct 22 17:34 . drwxr-xr-x 8 zhangbo staff 256 Oct 22 17:18 .. -rw-r--r--@ 1 zhangbo staff 6148 Oct 22 17:17 .DS_Store drwxr-xr-x 3 zhangbo staff 96 Oct 22 17:23 123
So we need update .DS_store to .DS_Store
Thanks to @arhadthedev show a more clean code