gh-60203: Always pass True/False as boolean arguments in tests #99983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unless we explicitly test non-bool values.
serhiy-storchaka
added
tests
serhiy-storchaka
requested review from
1st1,
asvetlov,
gvanrossum and
kumaraditya303
as code owners
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
|
GH-99986 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 4, 2022
…ythonGH-99983) Unless we explicitly test non-bool values. (cherry picked from commit 76f43fc) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Dec 4, 2022
… tests (pythonGH-99983) Unless we explicitly test non-bool values.. (cherry picked from commit 76f43fc) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-99989 is a backport of this pull request to the 3.10 branch. |
miss-islington
added a commit
that referenced
this pull request
Dec 4, 2022
) Unless we explicitly test non-bool values. (cherry picked from commit 76f43fc) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka
added a commit
that referenced
this pull request
Dec 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unless we explicitly test non-bool values.