Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate legacy functions #236

Merged
merged 6 commits into from
Oct 18, 2021
Merged

Deprecate legacy functions #236

merged 6 commits into from
Oct 18, 2021

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented Oct 17, 2021 •
edited
Loading

Ref #80 (addresses the next two steps in the deprecation process).

Still to do:

  • Update tests to capture the expectation (and suppress warnings in test suite).
  • Update changelog.

@jaraco jaraco marked this pull request as ready for review October 17, 2021 22:10
@jaraco jaraco requested a review from FFY00 October 17, 2021 22:12
@jaraco
Add section to the docs guiding the user on how to migrate (relying o…
ed3b2d3 
…n the _legacy module as a guide because it's so easy to read).
FFY00
FFY00 approved these changes Oct 17, 2021
View reviewed changes
Copy link
Member

@FFY00 FFY00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

importlib_resources/_legacy.py Outdated Show resolved Hide resolved
docs/using.rst Outdated Show resolved Hide resolved
@jaraco jaraco merged commit 8ac7ab5 into main Oct 18, 2021
@jaraco jaraco deleted the feature/deprecate-legacy branch October 18, 2021 17:55
@jaraco jaraco mentioned this pull request Oct 18, 2021
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FFY00 FFY00 FFY00 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaraco @FFY00