Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stubtest: enum completeness check #14692

Closed
srittau opened this issue Feb 13, 2023 · 2 comments
Closed

stubtest: enum completeness check #14692

srittau opened this issue Feb 13, 2023 · 2 comments

Comments

@srittau
Copy link
Contributor

srittau commented Feb 13, 2023

Feature

stubtest could do a completeness check for enums.

Pitch

This would be quite useful for cases like python/typeshed#9727, i.e. if enum values are added in later versions of a library.

@JelleZijlstra
Copy link
Member

Note that in the case you linked, the class is not an enum (at least not in the stub). But it would be useful for stubtest to flag missing class attributes whether or not the class is an enum.

@hauntsaninja
Copy link
Collaborator

stubtest does already do this. The issue is just that the typeshed third party stub tests default to passing --ignore-missing-stub
https://github.com/python/typeshed/blob/70f0f5488aed9952a5bea1d76eef9f97ce60dc40/tests/parse_metadata.py#L70

I've advocated against typeshed doing this in the past, current issue for this is python/typeshed#9538

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants