Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daemon support for --follow-imports=silent #9475

Open
rggjan opened this issue Sep 24, 2020 · 5 comments
Open

Daemon support for --follow-imports=silent #9475

rggjan opened this issue Sep 24, 2020 · 5 comments

Comments

@rggjan
Copy link

rggjan commented Sep 24, 2020

After #5870 is done, it would be nice to also support the missing silent option in following imports... :)

@rggjan rggjan added the feature label Sep 24, 2020
@gvanrossum
Copy link
Member

Do you want to work on this? What situation leads you to need this?

@rggjan
Copy link
Author

rggjan commented Sep 25, 2020

I just think this would be useful when starting to add mypy to an existing large code base.

As described here:

  • When running it with follow_imports = skip the not whitelisted but already annotated code is needlessly ignored
  • When running it with follow_imports = normal you might get thousands of errors, especially when for example disallow_untyped_defs = True is set
  • Running with follow_imports = silent would allow making use of annotated dependent code without forcing you to actually fix those thousands of errors...

@noncuro
Copy link

noncuro commented Jun 7, 2023

This would be really impactful for us! We're facing the same issue

@FeryET
Copy link

FeryET commented Jul 4, 2023

Any updates on this?

@shaperilio
Copy link

At the very least, this should be a warning and not prevent the daemon from running.

Use case: large, incorrectly / un-typed codebase. Trying to look at errors in a single file and clear them out. So I put follow_imports = skip in the config file so I can just run mypy file.py in the terminal. Now the daemon won't run, and that's what I'm using in VSCode.

The alternative to this is to always add the flag when running in the command line, or create an alias / shell script / whatever, but I'd really like this to be easy for everyone working in the codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants