Adds in_checked_function() to semanal similar to the one in checker
#11156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
commented
Sep 21, 2021
| @@ -3506,6 +3506,9 @@ def visit_lambda_expr(self, e: LambdaExpr) -> Type: | |||
| # Type check everything in the body except for the final return | |||
| # statement (it can contain tuple unpacking before return). | |||
| with self.chk.scope.push_function(e): | |||
| # Lambdas can have more than one element in body, | |||
There was a problem hiding this comment.
I've added this comment because it took me quite some time to understand how lambda can possibly have more than one body item.
There was a problem hiding this comment.
So can this happen only in Python 2?
There was a problem hiding this comment.
There might be other cases, I am not sure. I've mentioned a single example I found.
sobolevn
commented
Sep 21, 2021
JelleZijlstra
approved these changes
Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #11155