Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infra: Allow dismissing the historical note banner #3536

Closed
hauntsaninja opened this issue Nov 16, 2023 · 3 comments · Fixed by #3559
Closed

Infra: Allow dismissing the historical note banner #3536

hauntsaninja opened this issue Nov 16, 2023 · 3 comments · Fixed by #3559
Labels
infra Core infrastructure for building and rendering PEPs

Comments

@hauntsaninja
Copy link
Contributor

hauntsaninja commented Nov 16, 2023 •
edited
Loading

These notes take up more than a 1/3 of my screen and make it significantly harder to read the PEP. I can developer console it out of existence on my laptop, but not on my phone.
@hugovk hugovk changed the title Allow dismissing the historical note banner Infra: Allow dismissing the historical note banner Nov 16, 2023
@hugovk hugovk added the infra Core infrastructure for building and rendering PEPs label Nov 16, 2023
@hugovk
Copy link
Member

hugovk commented Nov 16, 2023

Example link: https://peps.python.org/pep-0654/

Perhaps another option is for the banner not to be sticky when the width and/or height of the browser is less than a given amount.

For example, it could never be sticky for mobile layouts.

@JacobCoffee
Copy link
Member

@hugovk can I grab this

@JelleZijlstra
Copy link
Member

Feel free to submit a PR!

JacobCoffee added a commit to JacobCoffee/peps that referenced this issue Dec 1, 2023
@JacobCoffee
feat(python#3536): add close button to canonical banner
7773fab
JacobCoffee added a commit to JacobCoffee/peps that referenced this issue Dec 1, 2023
@JacobCoffee
fix(python#3536): unset sticky for small screens
0cf7283
@JacobCoffee JacobCoffee mentioned this issue Dec 1, 2023
Merged
hauntsaninja pushed a commit that referenced this issue Dec 3, 2023
@JacobCoffee
Infra: update canonical banners to not stick on small screens (#3559)
ff0702e 
Updates small media sizes to not have a sticky banner
Adds a helper close button to optionally close banner

Closes #3536
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
infra Core infrastructure for building and rendering PEPs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Infra: update canonical banners to not stick on small screens JacobCoffee/peps
5 participants
@JelleZijlstra @hugovk @hauntsaninja @JacobCoffee and others