Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 765: Disallow return/break/continue that exit a finally block #4119

Merged
merged 10 commits into from
Nov 16, 2024

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Nov 15, 2024

Basic requirements (all PEP Types)

  • Read and followed PEP 1 & PEP 12
  • File created from the latest PEP template
  • PEP has next available number, & set in filename (pep-NNNN.rst), PR title (PEP 123: <Title of PEP>) and PEP header
  • Title clearly, accurately and concisely describes the content in 79 characters or less
  • Core dev/PEP editor listed as Author or Sponsor, and formally confirmed their approval
  • Author, Status (Draft), Type and Created headers filled out correctly
  • PEP-Delegate, Topic, Requires and Replaces headers completed if appropriate
  • Required sections included
    • Abstract (first section)
    • Copyright (last section; exact wording from template required)
  • Code is well-formatted (PEP 7/PEP 8) and is in code blocks, with the right lexer names if non-Python
  • PEP builds with no warnings, pre-commit checks pass and content displays as intended in the rendered HTML
  • Authors/sponsor added to .github/CODEOWNERS for the PEP

Standards Track requirements

  • PEP topic discussed in a suitable venue with general agreement that a PEP is appropriate
  • Suggested sections included (unless not applicable)
    • Motivation
    • Rationale
    • Specification
    • Backwards Compatibility
    • Security Implications
    • How to Teach This
    • Reference Implementation
    • Rejected Ideas
    • Open Issues
  • Python-Version set to valid (pre-beta) future Python version, if relevant
  • Any project stated in the PEP as supporting/endorsing/benefiting from the PEP formally confirmed such
  • Right before or after initial merging, PEP discussion thread created and linked to in Discussions-To and Post-History

📚 Documentation preview 📚: https://pep-previews--4119.org.readthedocs.build/pep-0765/

@iritkatriel iritkatriel requested a review from a team as a code owner November 15, 2024 21:37
@hugovk
Copy link
Member

hugovk commented Nov 15, 2024

You can use PEP number 765.

@iritkatriel iritkatriel changed the title Finally PEP 765: Disallow return/break/continue that exit a finally block Nov 15, 2024
peps/pep-0765.rst Outdated Show resolved Hide resolved
peps/pep-0765.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@ncoghlan ncoghlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks again for pursuing this research and proposal.

peps/pep-0765.rst Outdated Show resolved Hide resolved
peps/pep-0765.rst Outdated Show resolved Hide resolved
peps/pep-0765.rst Outdated Show resolved Hide resolved
peps/pep-0765.rst Outdated Show resolved Hide resolved
peps/pep-0765.rst Outdated Show resolved Hide resolved
peps/pep-0765.rst Show resolved Hide resolved
peps/pep-0765.rst Show resolved Hide resolved
peps/pep-0765.rst Outdated Show resolved Hide resolved
peps/pep-0765.rst Outdated Show resolved Hide resolved
peps/pep-0765.rst Outdated Show resolved Hide resolved
@hugovk hugovk added the new-pep A new draft PEP submitted for initial review label Nov 16, 2024
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@iritkatriel
Copy link
Member Author

Thank you @ncoghlan and @hugovk !

@iritkatriel iritkatriel merged commit f999497 into python:main Nov 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-pep A new draft PEP submitted for initial review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants